Make the nested if more readable

lordthorzonus · lordthorzonus · commit a846c5f6715f · 2017-03-12T15:36:57.000+02:00
diff --git a/src/DataLoader.php b/src/DataLoader.php
@@ -62,10 +62,8 @@ public function load($key)
             throw new \InvalidArgumentException(self::class . '::load must be called with a value, but got null');
         }
 
-        if ($this->options->shouldCache()) {
-            if ($this->promiseCache->get($key)) {
-                return $this->promiseCache->get($key);
-            }
+        if ($this->options->shouldCache() && $this->promiseCache->get($key)) {
+            return $this->promiseCache->get($key);
         }
 
         $promise = new Promise(

Original file line number	Diff line number	Diff line change
`@@ -62,10 +62,8 @@ public function load($key)`
`62`	`62`	`throw new \InvalidArgumentException(self::class . '::load must be called with a value, but got null');`
`63`	`63`	`}`
`64`	`64`
`65`		`- if ($this->options->shouldCache()) {`
`66`		`- if ($this->promiseCache->get($key)) {`
`67`		`- return $this->promiseCache->get($key);`
`68`		`- }`
	`65`	`+ if ($this->options->shouldCache() && $this->promiseCache->get($key)) {`
	`66`	`+ return $this->promiseCache->get($key);`
`69`	`67`	`}`
`70`	`68`
`71`	`69`	`$promise = new Promise(`