Skip to content

Commit f4bc5fe

Browse files
final cleanup
1 parent dddcc86 commit f4bc5fe

File tree

6 files changed

+18
-70
lines changed

6 files changed

+18
-70
lines changed

flights/flights-bundle-template/template/.github/workflows/flights_liquibase.yml.tmpl

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ jobs:
3131
runs-on: ubuntu-latest
3232
environment: test
3333
env:
34-
DATABRICKS_HOST: {{ "${{ secrets.DATABRICKS_HOST }}" }}
35-
DATABRICKS_TOKEN: {{ "${{ secrets.DATABRICKS_TOKEN_TST }}" }}
34+
DATABRICKS_HOST: {{ "${{ vars.DATABRICKS_HOST }}" }}
35+
DATABRICKS_TOKEN: {{ "${{ vars.DATABRICKS_TOKEN_TST }}" }}
3636
DATABRICKS_BUNDLE_ENV: dev # should be TST, 'dev' is set for demo purposes only
3737
defaults:
3838
run:
@@ -84,11 +84,13 @@ jobs:
8484
#----------------------------------------------
8585
- name: Run Liquibase connection test & update
8686
env:
87-
LIQUIBASE_COMMAND_URL: {{ "${{ secrets.DATABRICKS_JDBC_URL }}" }}
87+
LIQUIBASE_COMMAND_URL: {{ "${{ vars.DATABRICKS_JDBC_URL }}" }}
8888
LIQUIBASE_COMMAND_USERNAME: "token"
8989
LIQUIBASE_COMMAND_PASSWORD: {{ "${{ secrets.DATABRICKS_TOKEN_TST }}" }}
90+
LIQUIBASE_COMMAND_DEFAULT_CATALOG_NAME: {{ "${{ vars.LIQUIBASE_CATALOG_NAME }}" }}
91+
LIQUIBASE_COMMAND_DEFAULT_SCHEMA_NAME: {{ "${{ vars.LIQUIBASE_SCHEMA_NAME }}" }}
9092
run: |
91-
liquibase_download/liquibase update --changelog-file=./liquibase/root.changelog.xml --log-level INFO --defaultsFile=./liquibase.properties
93+
liquibase_download/liquibase update --changelog-file=./liquibase/root.changelog.xml --log-level INFO
9294

9395
#----------------------------------------------
9496
# Install dependencies and package
@@ -102,7 +104,7 @@ jobs:
102104
#----------------------------------------------
103105
- name: Run unit tests
104106
env:
105-
DATABRICKS_HOST: {{ "${{ secrets.DATABRICKS_HOST }}" }}
107+
DATABRICKS_HOST: {{ "${{ vars.DATABRICKS_HOST }}" }}
106108
DATABRICKS_TOKEN: {{ "${{ secrets.DATABRICKS_TOKEN_TST }}" }}
107109
DATABRICKS_SERVERLESS_COMPUTE_ID: "auto"
108110
run: |
@@ -115,9 +117,11 @@ jobs:
115117
#----------------------------------------------
116118
- name: Run job (in staging)
117119
env:
118-
DATABRICKS_HOST: {{ "${{ secrets.DATABRICKS_HOST }}" }}
120+
DATABRICKS_HOST: {{ "${{ vars.DATABRICKS_HOST }}" }}
119121
DATABRICKS_TOKEN: {{ "${{ secrets.DATABRICKS_TOKEN_TST }}" }}
120122
DATABRICKS_BUNDLE_ENV: dev # should be TST, 'dev' is set for demo purposes only
123+
BUNDLE_VAR_liquibase_catalog: {{ "${{ vars.LIQUIBASE_CATALOG_NAME }}" }}
124+
BUNDLE_VAR_liquibase_schema: {{ "${{ vars.LIQUIBASE_SCHEMA_NAME }}" }}
121125
run: |
122126
databricks bundle deploy; databricks bundle run flights_notebook; databricks bundle destroy --auto-approve
123127
{{ end }}

flights/flights-bundle-template/template/databricks.yml.tmpl

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,14 @@ include:
2121
- resources/dlt/*.yml
2222
2323
variables:
24+
{{ if .include_liquibase }}
25+
liquibase_catalog:
26+
liquibase_schema:
27+
{{end}}
2428
catalog:
25-
default: {{.catalog}}
29+
default: {{ if .include_liquibase }}${var.liquibase_catalog}{{else}}{{.catalog}}{{end}}
2630
database:
27-
default: ${resources.schemas.project_schema.name}
31+
default: {{ if .include_liquibase }}${var.liquibase_schema}{{else}}${resources.schemas.project_schema.name}{{end}}
2832
flights_dlt_schema:
2933
default: ${resources.schemas.project_schema.name}_dlt
3034
flights_test_schema:
@@ -62,7 +66,7 @@ targets:
6266
resources:
6367
schemas:
6468
project_schema:
65-
name: {{.database}}
69+
name: ${var.database}
6670
catalog_name: ${var.catalog}
6771
comment: "Schema for flight data"
6872

flights/flights-bundle-template/template/liquibase.properties.tmpl

Lines changed: 0 additions & 4 deletions
This file was deleted.

flights/flights-bundle-template/template/src/flights_main_notebook.py.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,5 @@ df_transformed = (
5757

5858
# COMMAND ----------
5959

60-
df_transformed.write.format("delta").mode("append").saveAsTable(raw_table_name)
60+
df_transformed.write.format("delta").mode("append").option("mergeSchema", "true").saveAsTable(raw_table_name)
6161
print(f"Succesfully wrote data to {raw_table_name}")

liquibase.properties

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/unit_utils/remove.py

Lines changed: 0 additions & 54 deletions
This file was deleted.

0 commit comments

Comments
 (0)