Skip to content

Commit 84dcff7

Browse files
have no assumption about error messages of third-party packages
1 parent b8f72d2 commit 84dcff7

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

tests/testthat/test-hooks.R

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ run_test("style-files",
3939

4040
run_test("style-files",
4141
suffix = "-fail-parse.R", cmd_args = c("--cache-root=styler"),
42-
std_err = "unexpected"
42+
std_err = ""
4343
)
4444

4545
# success with cmd args
@@ -110,16 +110,17 @@ run_test("style-files",
110110
file_name = "style-files",
111111
suffix = "-ignore-fail.R",
112112
cmd_args = "--cache-root=styler",
113-
std_err = "Invalid stylerignore sequences"
113+
std_err = ""
114114
)
115115

116116

117117
# fail with cmd args
118118
run_test("style-files",
119119
file_name = "style-files-cmd",
120120
suffix = "-success.R",
121-
std_err = ifelse(packageVersion("styler") < package_version("1.10.3"), "scope must be one", "`scope` must be one"),
122-
cmd_args = c("--scope=space", "--cache-root=styler")
121+
cmd_args = c("--scope=space", "--cache-root=styler"),
122+
std_err = "",
123+
expect_success = FALSE
123124
)
124125

125126
run_test("style-files",
@@ -485,7 +486,7 @@ run_test("roxygenize",
485486
run_test("roxygenize",
486487
file_name = c("man/flie.Rd" = "flie-true.Rd"),
487488
suffix = "",
488-
std_err = "Writing NAMESPACE",
489+
std_err = "",
489490
artifacts = c(
490491
"DESCRIPTION" = test_path("in/DESCRIPTION-no-deps.dcf"),
491492
"R/roxygenize.R" = test_path("in/roxygenize.R")

0 commit comments

Comments
 (0)