making updates as per lorenzwalthert

Author: kcphila

API

@@ -11,6 +11,7 @@ open_config(root = here::here())
 open_wordlist(root = here::here())
 path_pre_commit_exec(check_if_exists = TRUE)
 path_precommit_exec(check_if_exists = TRUE)
+precommit_docopt(doc, args = commandArgs(trailingOnly = TRUE), ...)
 robust_purl(path)
 roxygen_assert_additional_dependencies()
 roxygenize_with_cache(key, dirs)

R/testing.R

@@ -149,7 +149,7 @@ hook_state_create <- function(tempdir,
 
   # quote any individual filenames with spaces so the shell identifies them
   # each as a single term
-  files <- ifelse( grepl(' ', files), shQuote(files), files)
+  files <- shQuote(files)
 
   system2(paste0(Sys.getenv("R_HOME"), "/bin/Rscript"),
     args = as.character(c(path_executable, cmd_args, files)),

R/utils.R

@@ -89,14 +89,14 @@ git_init <- function(path = ".") {
 #' than an array/vector, and so this function wraps docopt
 #' to
 #'
-#' @param doc \code{character} vector with command line specification
-#' @param args \code{character} vector of commandline arguments.
-#'   Defaults to \code{commandArgs(trailingOnly=TRUE)}.
+#' @param doc `character` vector with command line specification
+#' @param args `character` vector of commandline arguments.
+#'   Defaults to `commandArgs(trailingOnly=TRUE)`.
 #' @param ... Additional parameters passed to `docopt`
 #' @family hook script helpers
 #' @keywords internal
 #' @export
-precommit_docopt <- function(doc, args = commandArgs(trailingOnly=TRUE), ...) {
+precommit_docopt <- function(doc, args = commandArgs(trailingOnly = TRUE), ...) {
   docopt::docopt(doc, c(args, ""), ...)
 }
 

tests/testthat/test-hooks.R

@@ -232,23 +232,6 @@ run_test(
 )
 
 
-# verify that functions that use docopt without arguments function as
-# expected with filenames that contain spaces
-
-run_test("parsable-R",
-  file_name = "parsable R with spaces",
-  suffix = "-success.R",
-  std_err = NULL
-)
-
-run_test("parsable-R",
-  file_name = "parsable R with spaces",
-  suffix = "-fail.R",
-  std_out = "Full context",
-  std_err = "1 1"
-)
-
-
 ### . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . ..
 ### spell-check                                                             ####
 # success