Merge pull request #423 from lorenzwalthert/issue-422

more context for `parsable-R`

Author: lorenzwalthert

NEWS.md

@@ -4,6 +4,11 @@ editor_options:
     wrap: 72
 ---
 
+# precommit v0.3.1.9000
+
+-   `parsable-R` hook now gives more context on where and how parsing
+    fails (#423).
+
 # precommit v0.3.1
 
 **User visible changes**

inst/hooks/exported/parsable-R.R

@@ -11,6 +11,9 @@ out <- lapply(files, function(path) {
 
   tryCatch(
     parse(path_),
-    error = function(x) stop("File ", path, " is not parsable", call. = FALSE)
+    error = function(error) {
+      cat(c("File ", path, " is not parsable. Full context:\n"))
+      stop(conditionMessage(error), call. = FALSE)
+    }
   )
 })

tests/testthat/test-hooks.R

@@ -169,12 +169,13 @@ run_test("parsable-R",
 )
 
 # failure
-run_test("parsable-R", suffix = "-fail.R", std_err = "not parsable")
+run_test("parsable-R", suffix = "-fail.R", std_out = "Full context", std_err = "1 1")
 
 run_test(
   "parsable-R",
   suffix = "-fail.Rmd",
-  std_err = "parsable-R-fail.Rmd is not parsable"
+  std_out = "parsable-R-fail.Rmd",
+  std_err = "1 1"
 )
 
 ### . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . ..