Merge pull request #477 from lorenzwalthert/python-3.10

Use python 3.10 by default for conda envs

Author: lorenzwalthert

R/exec.R

@@ -208,7 +208,10 @@ path_derive_precommit_exec_conda_impl <- function(conda_env) {
       ls <- reticulate::conda_list()
       path_reticulate <- fs::path_dir(ls[ls$name == conda_env, "python"][1])
       derived <- fs::path(
+        # if windows, this is r-precommit, otherwise,
+        # it's r-precommit/env and use just base directory
         path_reticulate,
+        # if windows, append Scripts/
         ifelse(is_windows(), "Scripts", ""),
         precommit_executable_file()
       )

R/install.R

@@ -55,9 +55,25 @@ install_precommit <- function(force = FALSE) {
 #' @keywords internal
 install_impl <- function() {
   if (!"r-precommit" %in% reticulate::conda_list()$name) {
-    reticulate::conda_create("r-precommit")
+    reticulate::conda_create("r-precommit", python_version = "3.11")
   }
   reticulate::conda_install("r-precommit", packages = "pre-commit")
+  if (path_derive_precommit_exec_conda() == "") {
+    base_dir <- grep(
+      "r-precommit", gsub("r-precommit.*", "r-precommit", reticulate::conda_list()$python, ),
+      value = TRUE
+    )[1]
+    rlang::abort(c(
+      paste0(
+        "Please open an issue on https://github.com/lorenzwalthert/precommit and ",
+        "report the below:\nFailed to install pre-commit in a location known to R ",
+        "precommit. Here are candidates from the conda root (",
+        base_dir,
+        "):"
+      ),
+      list.files(base_dir, pattern = "pre-commit", recursive = TRUE)
+    ))
+  }
 }
 
 #' Updates pre-commit on your system with conda

tests/testthat/test-conda.R

@@ -192,9 +192,10 @@ if (!on_cran()) {
       expect_match(version_precommit(), "[0-9]+\\.[0-9]+\\.[0-9]+")
     } else {
       uninstall_precommit(scope = "user", ask = "none", root = ".")
-      version <- "2.10.0"
+      version <- "3.3.2" # TODO make this automaticly the last version
       reticulate::conda_install("r-precommit", paste0("pre-commit==", version))
       expect_equal(version_precommit(), version)
+      skip_on_os("windows")
       expect_invisible(update_precommit(), 0)
       expect_false(version_precommit() == version)
     }