skip 8 tests about roots on CRAN since using something else than current working directory is rare and change in R or dependencies that would break the functionality very unlikely

lorenzwalthert · lorenzwalthert · commit d2339ad91db3 · 2024-03-30T19:12:03.000+08:00
diff --git a/tests/testthat/test-hook-codemeta-description-updated.R b/tests/testthat/test-hook-codemeta-description-updated.R
@@ -45,42 +45,44 @@ run_test("codemeta-description-update",
   }
 )
 
-# succeed in correct root
-run_test("codemeta-description-update",
-  file_name = c(
-    "rpkg/DESCRIPTION" = "DESCRIPTION",
-    "rpkg/codemeta.json" = "codemeta.json"
-  ),
-  cmd_args = "--root=rpkg",
-  suffix = "",
-  file_transformer = function(files) {
-    if (length(files) > 1) {
-      # transformer is called once on all files and once per file
-      content_2 <- readLines(files[2])
-      Sys.sleep(2)
-      writeLines(content_2, files[2])
+if (!on_cran()) {
+  # succeed in correct root
+  run_test("codemeta-description-update",
+    file_name = c(
+      "rpkg/DESCRIPTION" = "DESCRIPTION",
+      "rpkg/codemeta.json" = "codemeta.json"
+    ),
+    cmd_args = "--root=rpkg",
+    suffix = "",
+    file_transformer = function(files) {
+      if (length(files) > 1) {
+        # transformer is called once on all files and once per file
+        content_2 <- readLines(files[2])
+        Sys.sleep(2)
+        writeLines(content_2, files[2])
+      }
+      files
     }
-    files
-  }
-)
+  )
 
-# # fail in wrong root
-run_test("codemeta-description-update",
-  file_name = c(
-    "rpkg/DESCRIPTION" = "DESCRIPTION",
-    "rpkg/codemeta.json" = "codemeta.json",
-    "rpkg2/codemeta.json" = "README.md"
-  ),
-  cmd_args = "--root=rpkg2",
-  std_err = "No `DESCRIPTION` found in repository.",
-  suffix = "",
-  file_transformer = function(files) {
-    if (length(files) > 1) {
-      # transformer is called once on all files and once per file
-      content_2 <- readLines(files[2])
-      Sys.sleep(2)
-      writeLines(content_2, files[2])
+  # # fail in wrong root
+  run_test("codemeta-description-update",
+    file_name = c(
+      "rpkg/DESCRIPTION" = "DESCRIPTION",
+      "rpkg/codemeta.json" = "codemeta.json",
+      "rpkg2/codemeta.json" = "README.md"
+    ),
+    cmd_args = "--root=rpkg2",
+    std_err = "No `DESCRIPTION` found in repository.",
+    suffix = "",
+    file_transformer = function(files) {
+      if (length(files) > 1) {
+        # transformer is called once on all files and once per file
+        content_2 <- readLines(files[2])
+        Sys.sleep(2)
+        writeLines(content_2, files[2])
+      }
+      files
     }
-    files
-  }
-)
+  )
+}
diff --git a/tests/testthat/test-hook-deps-in-desc-R.R b/tests/testthat/test-hook-deps-in-desc-R.R
@@ -20,24 +20,26 @@ run_test("deps-in-desc",
 )
 
 # in sub directory with correct root
-run_test("deps-in-desc",
-  cmd_args = "--root=rpkg",
-  suffix = "-fail.R", std_err = "Dependency check failed",
-  file_transformer = function(files) {
-    fs::path_abs(fs::file_move(files, "rpkg"))
-  },
-  artifacts = c("rpkg/DESCRIPTION" = test_path("in/DESCRIPTION"))
-)
+if (!on_cran()) {
+  run_test("deps-in-desc",
+    cmd_args = "--root=rpkg",
+    suffix = "-fail.R", std_err = "Dependency check failed",
+    file_transformer = function(files) {
+      fs::path_abs(fs::file_move(files, "rpkg"))
+    },
+    artifacts = c("rpkg/DESCRIPTION" = test_path("in/DESCRIPTION"))
+  )
+  # in sub directory with correct root
+  run_test("deps-in-desc",
+    cmd_args = "--root=rpkg",
+    suffix = "-success.R", std_err = NULL,
+    file_transformer = function(files) {
+      fs::path_abs(fs::file_move(files, "rpkg"))
+    },
+    artifacts = c("rpkg/DESCRIPTION" = test_path("in/DESCRIPTION"))
+  )
+}
 
-# in sub directory with correct root
-run_test("deps-in-desc",
-  cmd_args = "--root=rpkg",
-  suffix = "-success.R", std_err = NULL,
-  file_transformer = function(files) {
-    fs::path_abs(fs::file_move(files, "rpkg"))
-  },
-  artifacts = c("rpkg/DESCRIPTION" = test_path("in/DESCRIPTION"))
-)
 
 # with :::
 run_test("deps-in-desc",
diff --git a/tests/testthat/test-hook-roxygenize.R b/tests/testthat/test-hook-roxygenize.R
@@ -17,45 +17,47 @@ run_test("roxygenize",
   }
 )
 
-# with outdated Rd present in correct root
-run_test("roxygenize",
-  file_name = c("rpkg/man/flie.Rd" = "flie.Rd"),
-  suffix = "",
-  std_err = NA,
-  cmd_args = "--root=rpkg",
-  std_out = "Writing NAMESPACE",
-  artifacts = c(
-    "rpkg/DESCRIPTION" = test_path("in/DESCRIPTION-no-deps.dcf"),
-    "rpkg/R/roxygenize.R" = test_path("in/roxygenize.R")
-  ),
-  file_transformer = function(files) {
-    withr::local_dir("rpkg")
-    git_init()
-    git2r::add(path = files)
-    # hack to add artifact to trigger diff_requires_roxygenize()
-    git2r::add(path = fs::path(fs::path_dir(fs::path_dir(files[1])), "R"))
-    files
-  }
-)
+if (!on_cran()) {
+  # with outdated Rd present in correct root
+  run_test("roxygenize",
+    file_name = c("rpkg/man/flie.Rd" = "flie.Rd"),
+    suffix = "",
+    std_err = NA,
+    cmd_args = "--root=rpkg",
+    std_out = "Writing NAMESPACE",
+    artifacts = c(
+      "rpkg/DESCRIPTION" = test_path("in/DESCRIPTION-no-deps.dcf"),
+      "rpkg/R/roxygenize.R" = test_path("in/roxygenize.R")
+    ),
+    file_transformer = function(files) {
+      withr::local_dir("rpkg")
+      git_init()
+      git2r::add(path = files)
+      # hack to add artifact to trigger diff_requires_roxygenize()
+      git2r::add(path = fs::path(fs::path_dir(fs::path_dir(files[1])), "R"))
+      files
+    }
+  )
+  # without Rd present
+  run_test("roxygenize",
+    file_name = c("rpkg1/R/roxygenize.R" = "roxygenize.R"),
+    suffix = "",
+    cmd_args = "--root=rpkg1",
+    std_err = "Please commit the new `.Rd` files",
+    artifacts = c(
+      "rpkg1/DESCRIPTION" = test_path("in/DESCRIPTION-no-deps.dcf"),
+      "rpkg2/R/roxygenize.R" = test_path("in/roxygenize.R")
+    ),
+    file_transformer = function(files) {
+      withr::local_dir("rpkg1")
+      git_init()
+      git2r::add(path = files)
+      files
+    }
+  )
+}
 
 
-# without Rd present
-run_test("roxygenize",
-  file_name = c("rpkg1/R/roxygenize.R" = "roxygenize.R"),
-  suffix = "",
-  cmd_args = "--root=rpkg1",
-  std_err = "Please commit the new `.Rd` files",
-  artifacts = c(
-    "rpkg1/DESCRIPTION" = test_path("in/DESCRIPTION-no-deps.dcf"),
-    "rpkg2/R/roxygenize.R" = test_path("in/roxygenize.R")
-  ),
-  file_transformer = function(files) {
-    withr::local_dir("rpkg1")
-    git_init()
-    git2r::add(path = files)
-    files
-  }
-)
 
 # with Rd present in wrong root
 run_test("roxygenize",
diff --git a/tests/testthat/test-hook-use-tidy-description.R b/tests/testthat/test-hook-use-tidy-description.R
@@ -1,22 +1,23 @@
 # success
 run_test("use-tidy-description", "DESCRIPTION", suffix = "")
 
-# in sub directory with correct root
-run_test("use-tidy-description",
-  "DESCRIPTION",
-  suffix = "",
-  cmd_args = "--root=rpkg",
-  artifacts = c("rpkg/DESCRIPTION" = test_path("in/DESCRIPTION"))
-)
 
 
-
-# in sub directory with incorrect root
-# Need to generate the directoy `rpkg` but without DESCRIPTION file.
-run_test("use-tidy-description",
-  "DESCRIPTION",
-  suffix = "",
-  cmd_args = "--root=rpkg",
-  std_err = "No `DESCRIPTION` found in repository.",
-  artifacts = c("rpkg/README.md" = test_path("in/README.md"))
-)
+if (!on_cran()) {
+  # in sub directory with correct root
+  run_test("use-tidy-description",
+    "DESCRIPTION",
+    suffix = "",
+    cmd_args = "--root=rpkg",
+    artifacts = c("rpkg/DESCRIPTION" = test_path("in/DESCRIPTION"))
+  )
+  # in sub directory with incorrect root
+  # Need to generate the directoy `rpkg` but without DESCRIPTION file.
+  run_test("use-tidy-description",
+    "DESCRIPTION",
+    suffix = "",
+    cmd_args = "--root=rpkg",
+    std_err = "No `DESCRIPTION` found in repository.",
+    artifacts = c("rpkg/README.md" = test_path("in/README.md"))
+  )
+}
