Skip to content

Commit e518d8f

Browse files
legacy compatibility is no longer explicitly tested, people who udpate the R package should also update the hook revision. This is explicitly required for new issues.
1 parent efaa00a commit e518d8f

File tree

2 files changed

+0
-116
lines changed

2 files changed

+0
-116
lines changed

.github/workflows/hook-tests-legacy.yml

Lines changed: 0 additions & 102 deletions
This file was deleted.

vignettes/testing.Rmd

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,6 @@ This package has five testing workflows:
3535
`run_test()` and check in the user R profile if it is set, and then
3636
activate the renv. This is done with `R_PRECOMMIT_HOOK_ENV`.
3737

38-
- Legacy hook testing: It is possible that someone updates the R
39-
package {precommit}, but not the hook revision (e.g. with
40-
`precommit::autoupdate()`) or vice versa. If the hook revision is
41-
updated to `>= 0.2.0`, all hook scripts and {precommit} functions
42-
called from the hook script are from the same version of
43-
{precommit}, so we don't need to test hook compatibility. If the R
44-
package is updated but not the hook revision, old hook scripts are
45-
called with while the {precommit} functions in them are from a new
46-
package version. Hence, we need compatibility between new packages
47-
and old hook scripts, which is exactly what is tested with this
48-
workflow. Until there are breaking changes in the *hook script
49-
helpers* family of exported functions, there should not be a
50-
problem.
51-
5238
- complete testing: Tests hooks as well as usethis like access
5339
functionality with latest CRAN packages, on all platforms, with all
5440
installation methods.

0 commit comments

Comments
 (0)