Commit 4fad44b
committed
feat(sync): Add checks when
I run into an issue providing a container ID of an detached container.
With the implementation before I got an `Uncaught TypeError` since there
is no type check whether `getContainerId()` returns a container so that
`map.get()` cannot be called. I took me a while to find the issue.
Thus I suggest to add some type checks when `containerId` is provided
with appropriate error message. This should result in a better developer
experience.containerId is provided1 parent b2bcee5 commit 4fad44b
1 file changed
Lines changed: 22 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
79 | | - | |
80 | | - | |
| 78 | + | |
81 | 79 | | |
82 | 80 | | |
83 | 81 | | |
| |||
94 | 92 | | |
95 | 93 | | |
96 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
97 | 116 | | |
98 | 117 | | |
99 | 118 | | |
| |||
0 commit comments