fix: resolve lint errors in handshake-auth.test.ts and simple-server.ts (#49)

- Replace arrow shorthand with block statements to avoid void expression returns
- Use addEventListener instead of onopen/onerror properties
- Remove unused 'expect' import and unused 'err' parameter
- Replace 'any' type with proper verifyClient function type

Co-authored-by: lody <[email protected]>

Author: lodyai[bot]

packages/loro-websocket/src/server/simple-server.ts

@@ -94,7 +94,14 @@ export class SimpleServer {
 
   start(): Promise<void> {
     return new Promise(resolve => {
-      const options: { port: number; host?: string; verifyClient?: any } = {
+      const options: {
+        port: number;
+        host?: string;
+        verifyClient?: (
+          info: { origin: string; secure: boolean; req: IncomingMessage },
+          cb: (res: boolean, code?: number, message?: string) => void
+        ) => void;
+      } = {
         port: this.config.port,
       };
       if (this.config.host) {

packages/loro-websocket/tests/handshake-auth.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect, beforeAll, afterAll } from "vitest";
+import { describe, it, beforeAll, afterAll } from "vitest";
 import { WebSocket } from "ws";
 import getPort from "get-port";
 import { SimpleServer } from "../src/server/simple-server";
@@ -38,8 +38,12 @@ describe("Handshake Auth", () => {
     });
 
     await new Promise<void>((resolve, reject) => {
-      ws.onopen = () => resolve();
-      ws.onerror = err => reject(err);
+      ws.addEventListener("open", () => {
+        resolve();
+      });
+      ws.addEventListener("error", err => {
+        reject(err);
+      });
     });
     ws.close();
   });
@@ -52,19 +56,25 @@ describe("Handshake Auth", () => {
     });
 
     await new Promise<void>((resolve, reject) => {
-      ws.onopen = () => reject(new Error("Should have failed"));
-      ws.onerror = err => {
+      ws.addEventListener("open", () => {
+        reject(new Error("Should have failed"));
+      });
+      ws.addEventListener("error", () => {
         resolve();
-      };
+      });
     });
   });
 
   it("should reject connection with missing cookie", async () => {
     const ws = new WebSocket(`ws://localhost:${port}`);
 
     await new Promise<void>((resolve, reject) => {
-      ws.onopen = () => reject(new Error("Should have failed"));
-      ws.onerror = () => resolve();
+      ws.addEventListener("open", () => {
+        reject(new Error("Should have failed"));
+      });
+      ws.addEventListener("error", () => {
+        resolve();
+      });
     });
   });
 });