Skip to content

Commit 5bbf825

Browse files
committed
test: remove unused skip logic in E2E tests
1 parent 137c51f commit 5bbf825

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

packages/loro-websocket/tests/e2e-elo.test.ts

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ import {
1414
} from "loro-protocol";
1515
import { EloAdaptor } from "loro-adaptors/loro";
1616

17-
let skip = false;
18-
1917
// Make WebSocket available globally for the client
2018
Object.defineProperty(globalThis, "WebSocket", {
2119
value: WebSocket,
@@ -291,13 +289,10 @@ describe("E2E: %ELO decrypt failure and unknown key handling", () => {
291289
});
292290

293291
afterAll(async () => {
294-
if (!skip && server) {
295-
await server.stop();
296-
}
292+
await server.stop();
297293
}, 15000);
298294

299295
it("client reports decrypt error for unknown keyId", async () => {
300-
if (skip) return;
301296
const client1 = new LoroWebsocketClient({ url: `ws://localhost:${port}` });
302297
const client2 = new LoroWebsocketClient({ url: `ws://localhost:${port}` });
303298
await Promise.all([client1.waitConnected(), client2.waitConnected()]);
@@ -371,7 +366,7 @@ async function waitForJoinOk(ws: WebSocket): Promise<void> {
371366
clearTimeout(t);
372367
resolve();
373368
}
374-
} catch {}
369+
} catch { }
375370
});
376371
});
377372
}
@@ -388,7 +383,7 @@ async function waitForAck(ws: WebSocket): Promise<Ack> {
388383
clearTimeout(t);
389384
resolve(msg);
390385
}
391-
} catch {}
386+
} catch { }
392387
});
393388
});
394389
}

packages/loro-websocket/tests/e2e-update-error.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ Object.defineProperty(globalThis, "WebSocket", {
2323
describe("E2E: onUpdateError", () => {
2424
let server: WebSocketServer;
2525
let port: number;
26-
let skip = false;
2726
let lastUpdates: Uint8Array[] = [];
2827

2928
beforeAll(async () => {
@@ -39,13 +38,11 @@ describe("E2E: onUpdateError", () => {
3938
});
4039
});
4140
} catch (e) {
42-
skip = true;
4341
console.warn("Skipping onUpdateError e2e: cannot start ws server", e);
4442
}
4543
});
4644

4745
afterAll(async () => {
48-
if (skip || !server) return;
4946
for (const client of server.clients) {
5047
try {
5148
client.terminate();
@@ -59,8 +56,6 @@ describe("E2E: onUpdateError", () => {
5956
});
6057

6158
it("invokes adaptor onUpdateError with original batch", async () => {
62-
if (skip) return;
63-
6459
const errors: Array<{ updates: Uint8Array[]; code: number; reason?: string }> = [];
6560
const adaptor = new LoroAdaptor(undefined, {
6661
onUpdateError: (updates, code, reason) => {

0 commit comments

Comments
 (0)