tiny prototype of how undo stack could work

Author: loudifier

src/CLGui/CLParameter.py

@@ -1,6 +1,7 @@
 import CLProject as clp
 from qtpy.QtWidgets import QWidget, QHBoxLayout, QVBoxLayout, QLabel, QLineEdit, QComboBox, QDoubleSpinBox, QAbstractSpinBox, QPushButton, QFileDialog, QCheckBox
 import numpy as np
+from CLGui import undo_stack
 
 # collection of combination classes for displaying and entering configuration parameters
 # typically a label on the left, text box or similar element in the middle, and sometimes a unit label or dropdown on the right
@@ -95,9 +96,11 @@ def valueChanged(new_val): # can also catch textChanged. textChanged and valueCh
                 new_val = int(round(new_val))
             #self.spin_box.setValue(self.value) # fires an extra callback, call self.set_value() instead
             self.set_value(min(max(new_val, self.min), self.max)) # update if rounded or changed to min/max
-            if not self.update_callback is None:
+            if self.update_callback is not None:
                 self.update_callback(self.value)
+            undo_stack.push(self.undo_redo, self.last_value)
             self.last_value = self.value
+        
         self.spin_box.valueChanged.connect(valueChanged)
 
         # Only add a unit label if the unit is specified
@@ -148,6 +151,12 @@ def set_numtype(self, new_type):
             self.spin_box.setDecimals(0)
             # default step value should still be 1
 
+    def undo_redo(self, undo_redo, value):
+        self.set_value(value)
+        self.last_value = value
+        if self.update_callback is not None:
+                self.update_callback(self.value)
+
 
 class CLParamDropdown(QWidget):
     def __init__(self, label_text, item_list, unit=None, editable=False):

src/CLGui/MainWindow.py

@@ -1,7 +1,7 @@
 import CLProject as clp
 from qtpy.QtWidgets import QMainWindow, QTabWidget, QTabBar, QGridLayout, QWidget, QApplication, QFileDialog, QErrorMessage, QMessageBox, QDialog, QDialogButtonBox, QVBoxLayout, QProxyStyle, QStyle, QLabel, QSizePolicy
 from qtpy.QtGui import QAction, QIcon, QPalette, QKeySequence, QPixmap
-from CLGui import ChirpTab, CLParamDropdown, CLParameter, QHSeparator
+from CLGui import ChirpTab, CLParamDropdown, CLParameter, QHSeparator, undo_stack
 from CLMeasurements import init_measurements, is_valid_measurement_name
 from CLAnalysis import generate_stimulus
 from pathlib import Path
@@ -161,6 +161,15 @@ def filterSelected(filter_string):
         file_menu.addAction(quit_action)
         quit_action.triggered.connect(self.close)
 
+
+        edit_menu = menubar.addMenu(' &Edit ')
+        edit_menu.setStyle(MenuProxyStyle(edit_menu.style()))
+
+        undo = QAction('Undo', self, shortcut=QKeySequence('Ctrl+Z'))
+        edit_menu.addAction(undo)
+        undo.triggered.connect(undo_stack.undo)
+        #todo: initialize disabled, add handle for undo stack to enable/disable undo/redo
+
 
         measurement_menu = menubar.addMenu(' &Measurement')
         file_menu.setStyle(MenuProxyStyle(file_menu.style()))

src/CLGui/Undo.py

@@ -0,0 +1,20 @@
+
+
+class UndoStack():
+    def __init__(self):
+        self.history = []
+        self.index = None
+
+    def push(self, callback, value):
+        self.history.append([callback, value])
+        if self.index is None:
+            self.index = 0
+        else:
+            self.index += 1
+
+    def undo(self):
+        self.history[self.index][0]('undo', self.history[self.index][1])
+        self.index -= 1
+    
+
+undo_stack = UndoStack()

src/CLGui/__init__.py

@@ -32,6 +32,7 @@ def __init__(self, parent=None):
 
 
 
+from CLGui.Undo import undo_stack
 from CLGui.CLTab import CLTab
 from CLGui.CLParameter import CLParameter, CLParamNum, CLParamDropdown, CLParamFile, FreqPointsParams
 from CLGui.QCollapsible.QCollapsible import QCollapsible