Upside Down Mode Not Working for Group Monitors Anymore

[cvsickle]

📑 I have found these related issues/pull requests

I can't find any issues or pull requests about this.

🛡️ Security Policy

• I have read and agree to Uptime Kuma's Security Policy.

📝 Description

Just updated from 2.0.2 to 2.1.3, and the group monitors I had on Upside Down mode aren't working anymore.

To verify, I created a new group monitor with two monitors inside, one up and one down. Both were pointed to google.com, and one was in Upside Down mode. With the group monitor in Upside Down mode, this group monitor should read up, but it reads down.

👟 Reproduction steps

• Create a new group monitor in upside down mode.
• Create two monitors inside both pointed to google.com, with ONE of them in Upside Down mode. This should result in one up and one down.
• With the group monitor in Upside Down mode, this group monitor should read up, but it reads down.

👀 Expected behavior

The group monitor should read up when in Upside down mode with one up monitor and one down monitor inside.

😓 Actual Behavior

The group monitor in Upside down mode seems to always read down when any of the inside monitors are down.

🐻 Uptime-Kuma Version

2.1.3

💻 Operating System and Arch

Docker

🌐 Browser

Edge

🖥️ Deployment Environment

• Runtime Environment:
  • Docker: Version 29.2.1
  • MariaDB: mariadb:lts
• Database:
  • MariaDB: External
• Database Storage:
  • Ceph on SSDs
• Uptime Kuma Setup:
  • Number of monitors: 80

📝 Relevant log output

[mmomjian]

Can confirm I am also affected by this.

[louislam]

Not quite sure yet, I think it is related to #6286.

cc: @MayMeow

[MayMeow]

I think I have identified the problem. My earlier changes to the group monitor explicitly override the status to 'DOWN' when the children are down.

https://github.com/louislam/uptime-kuma/pull/6286/changes#diff-b745a64509920ce8903f4d7df5dfb70a96e866402a656b051f8cb2d0bfed2e79R65

After removing this, it started behaving as expected. With the 'upside down' monitor type, it goes up when at least one child monitor is down.

cc: @louislam