apply suggestions

Author: lovasoa

src/ast/query.rs

@@ -1626,6 +1626,7 @@ pub struct TableAliasColumnDef {
 }
 
 impl TableAliasColumnDef {
+    /// Create a new table alias column definition with only a name and no type
     pub fn from_column_name(name: &str) -> Self {
         TableAliasColumnDef {
             name: Ident::new(name),

src/parser/mod.rs

@@ -8607,10 +8607,8 @@ impl<'a> Parser<'a> {
         }
     }
 
-    /// Parse a parenthesized comma-separated list of unqualified, possibly quoted identifiers
-    pub fn parse_table_alias_column_defs(
-        &mut self,
-    ) -> Result<Vec<TableAliasColumnDef>, ParserError> {
+    /// Parse a parenthesized comma-separated list of table alias column definitions.
+    fn parse_table_alias_column_defs(&mut self) -> Result<Vec<TableAliasColumnDef>, ParserError> {
         if self.consume_token(&Token::LParen) {
             let cols = self.parse_comma_separated(|p| {
                 let name = p.parse_identifier(false)?;

tests/sqlparser_common.rs

@@ -5581,7 +5581,7 @@ fn parse_table_function() {
 }
 
 #[test]
-fn parse_table_valued_function_with_alias_and_column_defs() {
+fn parse_select_with_alias_and_column_defs() {
     let sql = r#"SELECT * FROM jsonb_to_record('{"a": "x", "b": 2}'::JSONB) AS x (a TEXT, b INT)"#;
     let select = verified_only_select(sql);