Skip to content

Commit 46299d7

Browse files
committed
remove unused param
1 parent 8c4d082 commit 46299d7

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

topic_manager.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ func NewTopicManager(brokers []string, saramaConfig *sarama.Config, topicManager
4646
if err != nil {
4747
return nil, fmt.Errorf("Error creating the kafka client: %v", err)
4848
}
49-
return newTopicManager(brokers, saramaConfig, topicManagerConfig, client, checkBroker)
49+
return newTopicManager(saramaConfig, topicManagerConfig, client, checkBroker)
5050
}
5151

52-
func newTopicManager(brokers []string, saramaConfig *sarama.Config, topicManagerConfig *TopicManagerConfig, client sarama.Client, check checkFunc) (*topicManager, error) {
52+
func newTopicManager(saramaConfig *sarama.Config, topicManagerConfig *TopicManagerConfig, client sarama.Client, check checkFunc) (*topicManager, error) {
5353
if client == nil {
5454
return nil, errors.New("cannot create topic manager with nil client")
5555
}

topic_manager_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func TestTM_newTopicManager(t *testing.T) {
107107
bm.client.EXPECT().Brokers().Return([]*sarama.Broker{
108108
new(sarama.Broker),
109109
})
110-
tm, err := newTopicManager(tmTestBrokers, DefaultConfig(), NewTopicManagerConfig(), bm.client, trueCheckFunc)
110+
tm, err := newTopicManager(DefaultConfig(), NewTopicManagerConfig(), bm.client, trueCheckFunc)
111111
require.NoError(t, err)
112112
require.Equal(t, tm.client, bm.client)
113113
require.NotNil(t, tm.admin)
@@ -117,10 +117,10 @@ func TestTM_newTopicManager(t *testing.T) {
117117
defer ctrl.Finish()
118118
bm := newBuilderMock(ctrl)
119119

120-
_, err := newTopicManager(tmTestBrokers, nil, nil, bm.client, trueCheckFunc)
120+
_, err := newTopicManager(nil, nil, bm.client, trueCheckFunc)
121121
require.Error(t, err)
122122

123-
_, err = newTopicManager(tmTestBrokers, nil, NewTopicManagerConfig(), nil, trueCheckFunc)
123+
_, err = newTopicManager(nil, NewTopicManagerConfig(), nil, trueCheckFunc)
124124
require.Error(t, err)
125125
})
126126
t.Run("fail_check", func(t *testing.T) {
@@ -133,7 +133,7 @@ func TestTM_newTopicManager(t *testing.T) {
133133
new(sarama.Broker),
134134
})
135135

136-
_, err := newTopicManager(tmTestBrokers, DefaultConfig(), NewTopicManagerConfig(), bm.client, falseCheckFunc)
136+
_, err := newTopicManager(DefaultConfig(), NewTopicManagerConfig(), bm.client, falseCheckFunc)
137137
require.Equal(t, err.Error(), "broker check error")
138138
})
139139
}

0 commit comments

Comments
 (0)