Races detected in visitor code

[owenniles]

Description

When I run the visitor integration tests with race detection enabled, the tests fail because races are detected in two of the test cases. I am running a Kafka cluster with three brokers.

~/goka $ GOKA_SYSTEMTEST= GOKA_SYSTEMTEST_BROKERS=localhost:9091,localhost:9092,localhost:9093 go test ./systemtest -run TestProcessorVisit -race
(verbose errors omitted)
--- FAIL: TestProcessorVisit (37.64s)
    --- FAIL: TestProcessorVisit/visit-panic-slow (4.36s)
        testing.go:1398: race detected during execution of test
    --- FAIL: TestProcessorVisit/visit-shutdown (5.96s)
        testing.go:1398: race detected during execution of test
FAIL
FAIL    github.com/lovoo/goka/systemtest        37.898s
FAIL

I have confirmed that this behavior exists both on the latest version of master (183abf8) and v1.1.12. The tests pass when I leave off the -race flag.

Why does this matter?

I'm raising this issue because I believe the races are affecting my production code. I'm observing panics with stack traces identical to the one in #433. The race detector is detecting races in the same place. I will create a separate ticket for my specific case if I'm able to isolate the issue further.