Skip to content

Commit 87077a1

Browse files
committed
fix: restore variant to the report
Signed-off-by: James McCorrie <[email protected]>
1 parent c9317aa commit 87077a1

File tree

4 files changed

+22
-11
lines changed

4 files changed

+22
-11
lines changed

src/dvsim/flow/base.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -458,11 +458,20 @@ def gen_results(self, results: Sequence[CompletedJobStatus]) -> None:
458458
all_flow_results: Mapping[str, FlowResults] = {}
459459

460460
for item in self.cfgs:
461-
project = item.name
462-
item_results = [r for r in results if r.block.name == project]
461+
item_results = [
462+
res
463+
for res in results
464+
if res.block.name == item.name and res.block.variant == item.variant
465+
]
463466

464467
flow_results: FlowResults = item._gen_json_results(item_results)
465-
all_flow_results[project] = flow_results
468+
469+
# Convert to lowercase to match filename
470+
block_result_index = (
471+
f"{item.name}_{item.variant}" if item.variant else item.name
472+
).lower()
473+
474+
all_flow_results[block_result_index] = flow_results
466475

467476
# Write results to the report area.
468477
gen_block_report(
@@ -498,7 +507,6 @@ def gen_results(self, results: Sequence[CompletedJobStatus]) -> None:
498507
url=self.revision,
499508
),
500509
timestamp=timestamp,
501-
report_index={item.name: f"{item.name}.html" for item in self.cfgs},
502510
flow_results=all_flow_results,
503511
report_path=reports_dir,
504512
)

src/dvsim/report/data.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,6 @@ class ResultsSummary(BaseModel):
147147
flow_results: Mapping[str, FlowResults]
148148
"""Flow results."""
149149

150-
report_index: Mapping[str, Path]
151-
"""Index of the IP block reports."""
152-
153150
report_path: Path
154151
"""Path to the report JSON file."""
155152

src/dvsim/report/generate.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,21 @@ def gen_block_report(results: FlowResults, path: Path) -> None:
2424
path: output directory path
2525
2626
"""
27-
log.debug("generating report '%s'", results.block.name)
27+
file_name = (
28+
f"{results.block.name}_{results.block.variant}"
29+
if results.block.variant
30+
else results.block.name
31+
)
32+
33+
log.debug("generating report '%s'", file_name)
2834

2935
path.mkdir(parents=True, exist_ok=True)
3036

3137
# Save the JSON version
32-
(path / f"{results.block.name}.json").write_text(results.model_dump_json())
38+
(path / f"{file_name}.json").write_text(results.model_dump_json())
3339

3440
# Generate HTML report
35-
(path / f"{results.block.name}.html").write_text(
41+
(path / f"{file_name}.html").write_text(
3642
render_template(
3743
path="reports/block_report.html",
3844
data={"results": results},

src/dvsim/templates/reports/summary_report.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ <h2>Simulation Results: {{ top.name }}</h2>
105105
{% set flow = summary.flow_results[block_name] %}
106106
<tr>
107107
<td>
108-
<a href="{{ summary.report_index[block_name] }}">
108+
<a href="{{ block_name }}.html">
109109
{{ block_name }}
110110
</a>
111111
</td>

0 commit comments

Comments
 (0)