[testutils] Make aes compile on englishbreakfast

This testutil can compile without a CSRNG/EDN but the bazel target
did not correctly take that into account. This causes a problem
when compiling the doxygen target for multitop. This previously
went unnoticed because the aes testutils were only compiled on
earlgrey.

Signed-off-by: Amaury Pouly <[email protected]>

Author: pamaury

sw/device/lib/testing/BUILD

@@ -25,17 +25,29 @@ cc_library(
     name = "aes_testutils",
     srcs = ["aes_testutils.c"],
     hdrs = ["aes_testutils.h"],
+    defines = opentitan_if_ip(
+        "csrng",
+        # Assume that if csrng is present then so is the edn.
+        ["AES_TESTUTILS_HAS_EDN_AND_CSRNG"],
+        [],
+    ),
     target_compatible_with = [OPENTITAN_CPU],
     deps = [
         "//hw/ip/aes:model",
         "//hw/top:dt",
         "//sw/device/lib/dif:aes",
-        "//sw/device/lib/dif:csrng_shared",
-        "//sw/device/lib/dif:edn",
         "//sw/device/lib/runtime:ibex",
-        "//sw/device/lib/testing:csrng_testutils",
         "//sw/device/lib/testing/test_framework:check",
-    ],
+    ] + opentitan_if_ip(
+        "csrng",
+        # Assume that if csrng is present then so is the edn.
+        [
+            "//sw/device/lib/dif:csrng_shared",
+            "//sw/device/lib/dif:edn",
+            "//sw/device/lib/testing:csrng_testutils",
+        ],
+        [],
+    ),
 )
 
 cc_library(

sw/device/lib/testing/aes_testutils.c

@@ -8,7 +8,7 @@
 #include "sw/device/lib/dif/dif_aes.h"
 #include "sw/device/lib/testing/test_framework/check.h"
 
-#ifndef OPENTITAN_IS_ENGLISHBREAKFAST
+#ifdef AES_TESTUTILS_HAS_EDN_AND_CSRNG
 #include "sw/device/lib/dif/dif_csrng_shared.h"
 #include "sw/device/lib/testing/csrng_testutils.h"
 
@@ -35,7 +35,7 @@ enum {
   kAesTestutilsTimeout = (10 * 1000 * 1000),
 };
 
-#ifndef OPENTITAN_IS_ENGLISHBREAKFAST
+#ifdef AES_TESTUTILS_HAS_EDN_AND_CSRNG
 /**
  * Constants for switching AES masking off.
  */

sw/device/lib/testing/aes_testutils.h

@@ -6,12 +6,16 @@
 #define OPENTITAN_SW_DEVICE_LIB_TESTING_AES_TESTUTILS_H_
 
 #include "sw/device/lib/dif/dif_aes.h"
-#ifndef OPENTITAN_IS_ENGLISHBREAKFAST
+#include "sw/device/lib/runtime/ibex.h"
+#include "sw/device/lib/testing/test_framework/check.h"
+
+// The AES_TESTUTILS_HAS_EDN_AND_CSRNG define is created
+// by the Bazel rule to indicate the presence of the csrng
+// and edn IPs.
+#ifdef AES_TESTUTILS_HAS_EDN_AND_CSRNG
 #include "sw/device/lib/dif/dif_csrng.h"
 #include "sw/device/lib/dif/dif_edn.h"
 #endif
-#include "sw/device/lib/runtime/ibex.h"
-#include "sw/device/lib/testing/test_framework/check.h"
 
 /**
  * Returns the value of the AES status flag.
@@ -37,7 +41,7 @@ inline bool aes_testutils_get_status(dif_aes_t *aes, dif_aes_status_t status) {
   IBEX_TRY_SPIN_FOR(aes_testutils_get_status((aes_), (status_)) == (flag_), \
                     (timeout_usec_))
 
-#ifndef OPENTITAN_IS_ENGLISHBREAKFAST
+#ifdef AES_TESTUTILS_HAS_EDN_AND_CSRNG
 /**
  * Initializes the entropy complex for performing AES SCA measurements with
  * masking switched off.

sw/device/lib/testing/entropy_testutils.c

@@ -8,6 +8,9 @@
 #include "sw/device/lib/dif/dif_edn.h"
 #include "sw/device/lib/testing/test_framework/check.h"
 
+// The HAS_ENTROPY_SRC define is created by the Bazel rule to indicate
+// the presence of the entropy_src IP.
+
 #ifdef HAS_ENTROPY_SRC
 #include "sw/device/lib/dif/dif_entropy_src.h"
 #endif