Skip to content

Commit 4b9d6ff

Browse files
committed
[adc_ctrl,dv] Minor tweak to adc_ctrl_fsm_reset_vseq
At the start of this sequence it tries to set the filters to always match. It does so by making the range [0, 1023] (the whole input space) but then sets the cond flag to 1. That means that they will match values that are not in [0, 1023]... Invert the meaning. Rather oddly, the test seems to have worked equally well either way, so maybe this was completely pointless! But at least the comments and code are now consistent. Signed-off-by: Rupert Swarbrick <[email protected]>
1 parent dbb06c3 commit 4b9d6ff

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

hw/ip/adc_ctrl/dv/env/seq_lib/adc_ctrl_fsm_reset_vseq.sv

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,11 @@ class adc_ctrl_fsm_reset_vseq extends adc_ctrl_base_vseq;
102102
// Make sure filters will always match
103103
ral.adc_chn0_filter_ctl[0].min_v.set(0);
104104
ral.adc_chn0_filter_ctl[0].max_v.set(1023);
105-
ral.adc_chn0_filter_ctl[0].cond.set(1);
105+
ral.adc_chn0_filter_ctl[0].cond.set(0);
106106
ral.adc_chn0_filter_ctl[0].en.set(1);
107107
ral.adc_chn1_filter_ctl[0].min_v.set(0);
108108
ral.adc_chn1_filter_ctl[0].max_v.set(1023);
109-
ral.adc_chn1_filter_ctl[0].cond.set(1);
109+
ral.adc_chn1_filter_ctl[0].cond.set(0);
110110
ral.adc_chn1_filter_ctl[0].en.set(1);
111111
csr_wr(ral.adc_chn0_filter_ctl[0], ral.adc_chn0_filter_ctl[0].get());
112112
csr_wr(ral.adc_chn1_filter_ctl[0], ral.adc_chn1_filter_ctl[0].get());

0 commit comments

Comments
 (0)