[PATCH] [util,topgen] Check for duplicate constant declarations

Co-authored-by: Samuel Ortiz <[email protected]>
Signed-off-by: David Schrammel <[email protected]>

Author: 2 people

util/topgen/lib.py

@@ -44,6 +44,11 @@ def add_constant(self, constant_name: Name, docstring=""):
 
         value = len(self.constants)
 
+        # Check that we're not adding duplicates
+        for const in self.constants:
+            if full_name == const[0]:
+                raise ValueError('{} is already declared with value {}'.format(const[0], const[1]))
+
         self.constants.append((full_name, value, docstring))
 
         return full_name
@@ -148,6 +153,11 @@ def add_constant(self, constant_name: str, docstring="") -> str:
         full_name = constant_name
         value = self.enum_counter
         self.enum_counter += 1
+
+        # Check that we're not adding duplicates
+        for const in self.constants:
+            if full_name == const[0]:
+                raise ValueError('{} is already declared with value {}'.format(const[0], const[1]))
         self.constants.append((full_name, value, docstring))
         return full_name