[bazel] Move manual_test to //rules/opentitan

Signed-off-by: James Wainwright <[email protected]>
(cherry picked from commit c04dbf5)

Author: jwnrt

rules/opentitan/defs.bzl

@@ -31,6 +31,10 @@ load(
     _spx_key_by_name = "spx_key_by_name",
     _spx_key_for_lc_state = "spx_key_for_lc_state",
 )
+load(
+    "@lowrisc_opentitan//rules/opentitan:manual.bzl",
+    _opentitan_manual_test = "opentitan_manual_test",
+)
 load(
     "@lowrisc_opentitan//rules/opentitan:silicon.bzl",
     _silicon = "silicon",
@@ -101,6 +105,8 @@ rsa_key_by_name = _rsa_key_by_name
 spx_key_for_lc_state = _spx_key_for_lc_state
 spx_key_by_name = _spx_key_by_name
 
+opentitan_manual_test = _opentitan_manual_test
+
 # The default set of test environments for Earlgrey.
 EARLGREY_TEST_ENVS = {
     "//hw/top_earlgrey:fpga_cw310_sival_rom_ext": None,

rules/opentitan/manual.bzl

@@ -0,0 +1,42 @@
+# Copyright lowRISC contributors (OpenTitan project).
+# Licensed under the Apache License, Version 2.0, see LICENSE for details.
+# SPDX-License-Identifier: Apache-2.0
+
+def _opentitan_manual_test_impl(ctx):
+    executable = ctx.actions.declare_file("manual_test_wrapper")
+    ctx.actions.write(
+        output = executable,
+        content = "{runner} {testplan}".format(
+            runner = ctx.executable._runner.short_path,
+            testplan = ctx.file.testplan.short_path,
+        ),
+    )
+    return [
+        DefaultInfo(
+            runfiles = ctx.runfiles(
+                files = [
+                    ctx.executable._runner,
+                    ctx.file.testplan,
+                ],
+            ).merge(ctx.attr._runner[DefaultInfo].default_runfiles),
+            executable = executable,
+        ),
+    ]
+
+opentitan_manual_test = rule(
+    _opentitan_manual_test_impl,
+    attrs = {
+        "testplan": attr.label(
+            allow_single_file = [".hjson"],
+            doc = "Testplan with manual testpoints",
+            mandatory = True,
+        ),
+        "_runner": attr.label(
+            default = "//util:run_manual_tests",
+            executable = True,
+            cfg = "exec",
+        ),
+    },
+    doc = "Walks through the manual testpoints in a testplan",
+    test = True,
+)

rules/opentitan_test.bzl

@@ -671,42 +671,3 @@ def opentitan_functest(
             # For more see https://bazel.build/reference/be/general#test_suite.tags
         ],
     )
-
-def _manual_test_impl(ctx):
-    executable = ctx.actions.declare_file("manual_test_wrapper")
-    ctx.actions.write(
-        output = executable,
-        content = "{runner} {testplan}".format(
-            runner = ctx.executable._runner.short_path,
-            testplan = ctx.file.testplan.short_path,
-        ),
-    )
-    return [
-        DefaultInfo(
-            runfiles = ctx.runfiles(
-                files = [
-                    ctx.executable._runner,
-                    ctx.file.testplan,
-                ],
-            ).merge(ctx.attr._runner[DefaultInfo].default_runfiles),
-            executable = executable,
-        ),
-    ]
-
-manual_test = rule(
-    _manual_test_impl,
-    attrs = {
-        "testplan": attr.label(
-            allow_single_file = [".hjson"],
-            doc = "Testplan with manual testpoints",
-            mandatory = True,
-        ),
-        "_runner": attr.label(
-            default = "//util:run_manual_tests",
-            executable = True,
-            cfg = "exec",
-        ),
-    },
-    doc = "Walks through the manual testpoints in a testplan",
-    test = True,
-)

sw/device/silicon_creator/rom/BUILD

@@ -7,8 +7,14 @@ load("@rules_pkg//pkg:mappings.bzl", "pkg_files")
 load("//rules:cross_platform.bzl", "dual_cc_library", "dual_inputs")
 load("//rules:files.bzl", "output_groups")
 load("//rules:linker.bzl", "ld_library")
-load("//rules:opentitan_test.bzl", "manual_test")
-load("//rules/opentitan:defs.bzl", "OPENTITAN_CPU", "fpga_params", "opentitan_binary", "opentitan_test")
+load(
+    "//rules/opentitan:defs.bzl",
+    "OPENTITAN_CPU",
+    "fpga_params",
+    "opentitan_binary",
+    "opentitan_manual_test",
+    "opentitan_test",
+)
 load("//rules/opentitan:legacy.bzl", "legacy_rom_targets")
 
 package(default_visibility = ["//visibility:public"])
@@ -460,7 +466,7 @@ pkg_files(
     prefix = "earlgrey/rom",
 )
 
-manual_test(
+opentitan_manual_test(
     name = "manual_test",
     tags = [
         "manual",