Skip to content

Commit ad6a7c1

Browse files
committed
[bazel] Resolve incompatible_disallow_empty_glob errors
Future versions of Bazel will enable the `--incompatible_disallow_empty_glob` flag by default. Globs which return zero results must have the `allow_empty = True` parameter. The file export in `hw/top_earlgrey/data` for `autogen/` was invalid: `autogen` is now a package itself and the parent cannot export files from it. Signed-off-by: James Wainwright <[email protected]> (cherry picked from commit 677c57d)
1 parent dc0509e commit ad6a7c1

File tree

5 files changed

+24
-8
lines changed
  • hw/top_earlgrey/data
  • signing/examples/signatures
  • sw/device/silicon_creator
    • manuf/base/signatures
    • rom_ext/sival/signatures
    • rom/e2e/ate/signatures

5 files changed

+24
-8
lines changed

hw/top_earlgrey/data/BUILD

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
package(default_visibility = ["//visibility:public"])
66

7-
exports_files(glob(["autogen/**"]))
8-
97
filegroup(
108
name = "all_files",
119
srcs = glob(["**"]),

signing/examples/signatures/BUILD

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,16 @@ package(default_visibility = ["//visibility:public"])
66

77
filegroup(
88
name = "ecdsa_signatures",
9-
srcs = glob(["*.ecdsa_sig"]),
9+
srcs = glob(
10+
["*.ecdsa_sig"],
11+
allow_empty = True,
12+
),
1013
)
1114

1215
filegroup(
1316
name = "spx_signatures",
14-
srcs = glob(["*.spx_sig"]),
17+
srcs = glob(
18+
["*.spx_sig"],
19+
allow_empty = True,
20+
),
1521
)

sw/device/silicon_creator/manuf/base/signatures/BUILD

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,8 @@ filegroup(
1111

1212
filegroup(
1313
name = "spx_signatures",
14-
srcs = glob(["*.spx_sig"]),
14+
srcs = glob(
15+
["*.spx_sig"],
16+
allow_empty = True,
17+
),
1518
)

sw/device/silicon_creator/rom/e2e/ate/signatures/BUILD

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,8 @@ filegroup(
1111

1212
filegroup(
1313
name = "spx_signatures",
14-
srcs = glob(["*.spx_sig"]),
14+
srcs = glob(
15+
["*.spx_sig"],
16+
allow_empty = True,
17+
),
1518
)

sw/device/silicon_creator/rom_ext/sival/signatures/BUILD

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,16 @@ package(default_visibility = ["//visibility:public"])
66

77
filegroup(
88
name = "ecdsa_signatures",
9-
srcs = glob(["*.ecdsa_sig"]),
9+
srcs = glob(
10+
["*.ecdsa_sig"],
11+
allow_empty = True,
12+
),
1013
)
1114

1215
filegroup(
1316
name = "spx_signatures",
14-
srcs = glob(["*.spx_sig"]),
17+
srcs = glob(
18+
["*.spx_sig"],
19+
allow_empty = True,
20+
),
1521
)

0 commit comments

Comments
 (0)