[bazel] Move vmem_file rules to cc.bzl

Signed-off-by: James Wainwright <[email protected]>
(cherry picked from commit 0e24bd6)

Author: jwnrt

rules/opentitan/legacy.bzl

@@ -4,6 +4,7 @@
 
 load(
     "@lowrisc_opentitan//rules/opentitan:transform.bzl",
+    "convert_to_vmem",
     _obj_transform = "obj_transform",
 )
 load("@lowrisc_opentitan//rules:rv.bzl", "rv_rule")
@@ -53,3 +54,28 @@ obj_transform = rv_rule(
     },
     toolchains = ["@rules_cc//cc:toolchain_type"],
 )
+
+def _vmem_file_impl(ctx):
+    outputs = [convert_to_vmem(ctx)]
+    return [
+        DefaultInfo(
+            files = depset(outputs),
+            data_runfiles = ctx.runfiles(files = outputs),
+        ),
+    ]
+
+vmem_file = rv_rule(
+    implementation = _vmem_file_impl,
+    attrs = {
+        "src": attr.label(
+            allow_single_file = True,
+            doc = "Binary file to convert to vmem format",
+        ),
+        "word_size": attr.int(
+            default = 64,
+            doc = "Word size of VMEM file",
+            mandatory = True,
+            values = [32, 64],
+        ),
+    },
+)

rules/opentitan/transform.bzl

@@ -100,7 +100,7 @@ def convert_to_vmem(ctx, **kwargs):
         output = "{}.{}.vmem".format(name, word_size)
 
     output = ctx.actions.declare_file(output)
-    src = get_override(ctx, "attr.src", kwargs)
+    src = get_override(ctx, "file.src", kwargs)
 
     ctx.actions.run(
         outputs = [output],

sw/device/silicon_creator/manuf/base/binaries/BUILD

@@ -2,12 +2,9 @@
 # Licensed under the Apache License, Version 2.0, see LICENSE for details.
 # SPDX-License-Identifier: Apache-2.0
 
-load(
-    "//rules:opentitan.bzl",
-    "bin_to_vmem",
-    "scramble_flash_vmem",
-)
+load("//rules:opentitan.bzl", "scramble_flash_vmem")
 load("//rules/opentitan:cc.bzl", "exec_env_filegroup")
+load("//rules/opentitan:legacy.bzl", "vmem_file")
 load("//rules:files.bzl", "copy_files")
 
 package(default_visibility = ["//visibility:public"])
@@ -42,10 +39,10 @@ exec_env_filegroup(
 
 # The below rule sets (bin_to_vmem, scramble_flash_vmem, and filegroup)
 # are needed to run the perso bin in sim.
-bin_to_vmem(
+vmem_file(
     name = "ft_personalize_sival_silicon_creator_vmem64_signed",
     testonly = True,
-    bin = ":ft_personalize_sival_silicon_creator.signed.bin",
+    src = ":ft_personalize_sival_silicon_creator.signed.bin",
     word_size = 64,  # Backdoor-load VMEM image uses 64-bit words
 )
 

sw/device/silicon_creator/rom/e2e/BUILD

@@ -4,11 +4,8 @@
 
 load("@bazel_skylib//lib:dicts.bzl", "dicts")
 load("//rules:const.bzl", "CONST", "hex_digits")
-load(
-    "//rules:opentitan.bzl",
-    "bin_to_vmem",
-    "scramble_flash_vmem",
-)
+load("//rules:opentitan.bzl", "scramble_flash_vmem")
+load("//rules/opentitan:legacy.bzl", "vmem_file")
 load("//rules/opentitan:keyutils.bzl", "ECDSA_ONLY_KEY_STRUCTS")
 load(
     "//rules:otp.bzl",
@@ -235,13 +232,13 @@ opentitan_test(
     ]
 ]
 
-# The below three rule sets (bin_to_vmem, scramble_flash_vmem, and filegroup)
+# The below three rule sets (vmem_file, scramble_flash_vmem, and filegroup)
 # are needed to run `sigverify_always` tests in DV.
 [
-    bin_to_vmem(
+    vmem_file(
         name = "empty_test_slot_{}_{}_corrupted_sim_dv_vmem64_signed".format(slot, key),
         testonly = True,
-        bin = ":empty_test_slot_{}_{}_corrupted_sim_dv_signed_bin".format(slot, key),
+        src = ":empty_test_slot_{}_{}_corrupted_sim_dv_signed_bin".format(slot, key),
         word_size = 64,  # Backdoor-load VMEM image uses 64-bit words
     )
     for slot in SLOTS

sw/device/silicon_creator/rom/e2e/ate/binaries/BUILD

@@ -2,12 +2,9 @@
 # Licensed under the Apache License, Version 2.0, see LICENSE for details.
 # SPDX-License-Identifier: Apache-2.0
 
-load(
-    "//rules:opentitan.bzl",
-    "bin_to_vmem",
-    "scramble_flash_vmem",
-)
+load("//rules:opentitan.bzl", "scramble_flash_vmem")
 load("//rules/opentitan:cc.bzl", "exec_env_filegroup")
+load("//rules/opentitan:legacy.bzl", "vmem_file")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -34,10 +31,10 @@ _DV_EXEC_ENVS = [
 ]
 
 [
-    bin_to_vmem(
+    vmem_file(
         name = "ate_gpio_toggle_test_{}_vmem64_signed".format(env),
         testonly = True,
-        bin = ":ate_gpio_toggle_test_{}.signed.bin".format(env),
+        src = ":ate_gpio_toggle_test_{}.signed.bin".format(env),
         word_size = 64,  # Backdoor-load VMEM image uses 64-bit words
     )
     for env in _DV_EXEC_ENVS