[ot] hw/opentitan: ot_spi_device: fix address parsing in read SFDP

The bytes are received over the wire and stored in the buffer
most-significant byte first (big-endian), so the dummy byte is the last
byte not the first.

Signed-off-by: Alice Ziuziakowska <[email protected]>

Author: ziuziakowska

hw/opentitan/ot_spi_device.c

@@ -1117,8 +1117,7 @@ static void ot_spi_device_flash_exec_read_sfdp(OtSPIDeviceState *s)
 {
     SpiDeviceFlash *f = &s->flash;
 
-    unsigned address = ldl_be_p(f->src);
-    address &= (1u << 24u) - 1u; /* discard dummy byte */
+    unsigned address = ldl_be_p(f->src) >> 8u; /* discard dummy byte */
     f->pos = address % SPI_SRAM_SFDP_SIZE;
     f->len = SPI_SRAM_SFDP_SIZE;
     f->src = &((uint8_t *)s->sram)[SPI_SRAM_SFDP_OFFSET];