Skip to content

Commit 3703a82

Browse files
committed
[ot] docs/opentitan: earlgrey: Update Keymgr status in docs
Also document the final known limitations and TODOs for the `keymgr` in the prologue. Signed-off-by: Alex Jones <[email protected]>
1 parent 0a77734 commit 3703a82

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

docs/opentitan/earlgrey.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313

1414
### Near feature-complete devices
1515

16+
* Key manager
17+
* Almost feature complete
18+
* Missing entropy reseeding, and support for KMAC masking (when available)
1619
* AES
1720
* missing side-loading
1821
* Alert controller
@@ -89,7 +92,6 @@ any useful feature (only allow guest test code to execute as expected).
8992
Some just use generic `UNIMP` devices to define a memory region.
9093

9194
* Analog Sensor Top
92-
* Key manager
9395
* Pattern Generator
9496
* Pinmux
9597
* PWM

hw/opentitan/ot_keymgr.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,14 @@
2424
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
2525
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2626
* THE SOFTWARE.
27+
*
28+
* Known limitations:
29+
* - Entropy reseeding is not currently supported; the value in the shadowed
30+
* `RESEED_INTERVAL_THRESHOLD` register is ignored.
31+
* - Currently the keymgr is designed without KMAC masking. If KMAC masking
32+
* is enabled, a small amount of logic (KMAC data / key integrity checks)
33+
* needs to be updated to use both key shares correctly.
34+
* - Some faults may not be modelled completely accurately (i.e., untested).
2735
*/
2836

2937
#include "qemu/osdep.h"

0 commit comments

Comments
 (0)