[ot] hw/riscv: dj+eg: remove default OTP scrambling values

Providing defaults here could be error prone. Instead, require that
these properties are set by the `cfggen.py` INI file.

There is already a trace in `ot_otp_dj_configure_scrmbl_key` and
`ot_otp_dj_configure_digest` when these properties are not set.

Signed-off-by: James Wainwright <[email protected]>

Author: jwnrt

hw/riscv/ot_darjeeling.c

@@ -1104,18 +1104,7 @@ static const IbexDeviceDef ot_dj_soc_devices[] = {
             OT_DJ_SOC_DEVLINK("backend", OTP_BACKEND)
         ),
         .prop = IBEXDEVICEPROPDEFS(
-            IBEX_DEV_UINT_PROP("edn-ep", 1u),
-            IBEX_DEV_STRING_PROP("scrmbl_key",
-                "cebeb96ffe0eced795f8b2cfe23c1e51"
-                "9e4fa08047a6bcfb811b04f0a479006e"),
-            IBEX_DEV_STRING_PROP("digest_const",
-                "e048b657396b4b83277195fc471e4b26"),
-            IBEX_DEV_STRING_PROP("digest_iv",
-                "4d5a89aa9109294a"),
-            IBEX_DEV_STRING_PROP("sram_const",
-                "63b9485a3856c417cf7a50a9a91ef7f7"),
-            IBEX_DEV_STRING_PROP("sram_iv",
-                "bee3958332f2939b")
+            IBEX_DEV_UINT_PROP("edn-ep", 1u)
         ),
     },
     [OT_DJ_SOC_DEV_OTP_BACKEND] = {

hw/riscv/ot_earlgrey.c

@@ -567,20 +567,6 @@ static const IbexDeviceDef ot_eg_soc_devices[] = {
         ),
         .prop = IBEXDEVICEPROPDEFS(
             IBEX_DEV_UINT_PROP("edn-ep", 1u)
-            // Scrambling support is yet to be backported from Darjeeling
-            // implementation. Those are the Earlgrey constants defined for
-            // Earlgrey-M2.5.2-RC0:
-            // IBEX_DEV_STRING_PROP("scrmbl_key",
-            //     "605fefe9977b00b6fdc21d577a172d04"
-            //     "7dcf0eebbdd268afd4e2506df1d0603f"),
-            // IBEX_DEV_STRING_PROP("digest_const",
-            //     "30faa0c47e3809585a24109fbc53e920"),
-            // IBEX_DEV_STRING_PROP("digest_iv",
-            //     "af12b341a53780ab"),
-            // IBEX_DEV_STRING_PROP("sram_const",
-            //     "5f2c075769000c39cda36eab93cd263d"),
-            // IBEX_DEV_STRING_PROP("sram_iv",
-            //     "f2dae31d857d1d39")
         ),
     },
     [OT_EG_SOC_DEV_OTP_BACKEND] = {