Rename the effect type effects for OCaml 5.3 keyword compatibility

Author: bacam

src/lib/ast_util.ml

@@ -730,7 +730,7 @@ let mk_typquant qis = TypQ_aux (TypQ_tq qis, Parse_ast.Unknown)
 
 let mk_fexp id exp = FE_aux (FE_fexp (id, exp), no_annot)
 
-type effect = bool
+type effects = bool
 
 let no_effect = false
 let monadic_effect = true

src/lib/ast_util.mli

@@ -295,16 +295,16 @@ val constraint_conj : n_constraint -> n_constraint list
 (** Same as constraint_conj but for disjunctions *)
 val constraint_disj : n_constraint -> n_constraint list
 
-type effect
+type effects
 
-val no_effect : effect
-val monadic_effect : effect
+val no_effect : effects
+val monadic_effect : effects
 
-val effectful : effect -> bool
+val effectful : effects -> bool
 
-val equal_effects : effect -> effect -> bool
-val subseteq_effects : effect -> effect -> bool
-val union_effects : effect -> effect -> effect
+val equal_effects : effects -> effects -> bool
+val subseteq_effects : effects -> effects -> bool
+val union_effects : effects -> effects -> effects
 
 (** {2 Functions for building numeric expressions} *)
 

src/lib/type_check.ml

@@ -1290,7 +1290,7 @@ let can_be_undefined ~at:l env typ =
 type tannot' = {
   env : Env.t;
   typ : typ;
-  monadic : effect;
+  monadic : effects;
   expected : typ option;
   instantiation : typ_arg KBindings.t option;
 }

src/lib/type_check.mli

@@ -416,10 +416,10 @@ val env_of_mpat : tannot mpat -> Env.t
 val typ_of_mpexp : tannot mpexp -> typ
 val env_of_mpexp : tannot mpexp -> Env.t
 
-val effect_of : tannot exp -> effect
-val effect_of_pat : tannot pat -> effect
-val effect_of_annot : tannot -> effect
-val add_effect_annot : tannot -> effect -> tannot
+val effect_of : tannot exp -> effects
+val effect_of_pat : tannot pat -> effects
+val effect_of_annot : tannot -> effects
+val add_effect_annot : tannot -> effects -> tannot
 
 (* Returns the type that an expression was checked against, if any.
    Note that these may be removed if an expression is rewritten. *)