Merge pull request #209 from LowlyDBA/development

Development

Author: lowlydba

appveyor/sqlcover/Coverage.opencoverxml

@@ -12,7 +12,7 @@ sp_helpme - A drop-in modern alternative to sp_help.
 
 Part of the DBA MultiTool http://dba-multitool.org
 
-Version: 20210610
+Version: 20210622
 
 MIT License
 
@@ -102,7 +102,7 @@ BEGIN
 					and [ep].[name] = @ExtendedPropertyName
 					AND [ep].[minor_id] = 0
 					AND [ep].[class] = 1
-			ORDER BY [Owner] ASC, [Object_type] DESC, [name] ASC;';
+			ORDER BY [Owner] ASC, [Object_type] DESC, [Name] ASC;';
 		SET @ParmDefinition = N'@ExtendedPropertyName SYSNAME';
 
 		EXEC sp_executesql @SQLString
@@ -162,7 +162,7 @@ BEGIN
 	-- If @ObjectName not in sysobjects, try systypes
 	IF @ObjID IS NULL
 	BEGIN
-		SET @SQLSTring = N'SELECT @ObjID = user_type_id
+		SET @SQLString = N'SELECT @ObjID = user_type_id
 							FROM sys.types
 							WHERE name = PARSENAME(@ObjectName,1);';
 		SET @ParmDefinition = N'@ObjectName SYSNAME
@@ -388,7 +388,7 @@ BEGIN
 				AND deps.deptype = 1;';
 		SET @ParmDefinition = N'@ObjID INT, @HasDepen INT OUTPUT';
 
-		EXEC sp_executeSQL @SQLString
+		EXEC sp_executesql @SQLString
 			,@ParmDefinition
 			,@ObjID
 			,@HasDepen OUTPUT;

appveyor/sqlcover/[dbo].[sp_helpme]

@@ -19,24 +19,24 @@ sp_sizeoptimiser - Recommends space saving measures for data footprints.
 
 Part of the DBA MultiTool http://dba-multitool.org
 
-Version: 20201110
+Version: 20210622
 
 MIT License
 
 Copyright (c) 2020 John McCall
 
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated 
-documentation files (the "Software"), to deal in the Software without restriction, including without limitation 
-the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, 
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated
+documentation files (the "Software"), to deal in the Software without restriction, including without limitation
+the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software,
 and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 
-The above copyright notice and this permission notice shall be included in all copies or substantial 
+The above copyright notice and this permission notice shall be included in all copies or substantial
 portions of the Software.
 
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED 
-TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL 
-THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF 
-CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER 
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED
+TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF
+CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 DEALINGS IN THE SOFTWARE.
 
 =========
@@ -48,7 +48,7 @@ Example:
 	INSERT INTO @include ([database_name])
 	VALUES (N'WideWorldImporters');
 
-	EXEC [dbo].[sp_sizeoptimiser] @IncludeDatabases = @include														
+	EXEC [dbo].[sp_sizeoptimiser] @IncludeDatabases = @include
 */
 
 BEGIN
@@ -130,8 +130,8 @@ BEGIN
 				INSERT INTO #Databases
 				SELECT [sd].[name]
 				FROM [sys].[databases] AS [sd]
-				WHERE NOT EXISTS (SELECT [d].[database_name] 
-									FROM @IncludeDatabases AS [d] 
+				WHERE NOT EXISTS (SELECT [d].[database_name]
+									FROM @IncludeDatabases AS [d]
 									WHERE [sd].[name] COLLATE database_default = REPLACE(REPLACE([d].[database_name], '[', ''), ']', ''))
 					AND DATABASEPROPERTYEX([sd].[name], 'UPDATEABILITY') = N'READ_WRITE'
 					AND DATABASEPROPERTYEX([sd].[name], 'USERACCESS') = N'MULTI_USER'
@@ -183,7 +183,7 @@ BEGIN
 			BEGIN;
 				SET @HasPersistedSamplePercent = 1;
 			END;
-		
+
 		IF (@Verbose = 1)
 			BEGIN;
 				/* Print info */
@@ -271,7 +271,7 @@ BEGIN
 			END;
 		BEGIN;
 			SET @CheckSQL = N'';
-			SELECT @CheckSQL = @CheckSQL + 
+			SELECT @CheckSQL = @CheckSQL +
 				N'USE ' + QUOTENAME([database_name]) + N';
 				INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 				SELECT 	@CheckNumber
@@ -304,7 +304,7 @@ BEGIN
 			END;
 		BEGIN;
 			SET @CheckSQL = N'';
-			SELECT @CheckSQL = @CheckSQL + 
+			SELECT @CheckSQL = @CheckSQL +
 				N'USE ' + QUOTENAME([database_name]) +  N'; WITH archaic AS (
 				SELECT 	QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name) AS [obj_name]
 						,QUOTENAME(c.name) AS [col_name]
@@ -353,7 +353,7 @@ BEGIN
 			END;
 		BEGIN;
 			SET @CheckSQL = N'';
-			SELECT @CheckSQL = @CheckSQL + 
+			SELECT @CheckSQL = @CheckSQL +
 				N'USE ' + QUOTENAME([database_name]) + ';
 				WITH UnspecifiedVarChar AS (
 					SELECT	QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name) AS [obj_name]
@@ -391,7 +391,7 @@ BEGIN
 			END;
 		BEGIN;
 			SET @CheckSQL = N'';
-			SELECT @CheckSQL = @CheckSQL + 
+			SELECT @CheckSQL = @CheckSQL +
 				N'USE ' + QUOTENAME([database_name]) + N';
 				INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 				SELECT @CheckNumber
@@ -423,7 +423,7 @@ BEGIN
 			IF (@IsExpress = 1)
 				BEGIN;
 					SET @CheckSQL = N'';
-					SELECT @CheckSQL = @CheckSQL + 
+					SELECT @CheckSQL = @CheckSQL +
 						N'USE ' + QUOTENAME([database_name]) + N';
 						INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 						SELECT	@CheckNumber
@@ -457,7 +457,7 @@ BEGIN
 			END;
 		BEGIN;
 			SET @CheckSQL = N'';
-			SELECT @CheckSQL = @CheckSQL + 
+			SELECT @CheckSQL = @CheckSQL +
 				N'USE ' + QUOTENAME([database_name]) + N';
 				INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 				SELECT 	@CheckNumber
@@ -486,7 +486,7 @@ BEGIN
 			END;
 		BEGIN;
 			SET @CheckSQL = N'';
-			SELECT @CheckSQL = @CheckSQL + 
+			SELECT @CheckSQL = @CheckSQL +
 				N'USE ' + QUOTENAME([database_name]) + N';
 				INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 				SELECT 	@CheckNumber
@@ -517,7 +517,7 @@ BEGIN
 			IF (@IsExpress = 1)
 				BEGIN;
 					SET @CheckSQL = N'';
-					SELECT @CheckSQL = @CheckSQL + 
+					SELECT @CheckSQL = @CheckSQL +
 						N'USE ' + QUOTENAME([database_name]) + N';
 						INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 						SELECT  @CheckNumber
@@ -552,7 +552,7 @@ BEGIN
 			END;
 		BEGIN;
 			SET @CheckSQL = N'';
-			SELECT @CheckSQL = @CheckSQL + 
+			SELECT @CheckSQL = @CheckSQL +
 				N'USE ' + QUOTENAME([database_name]) + N';
 				INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 				SELECT 	@CheckNumber
@@ -584,7 +584,7 @@ BEGIN
 			END;
 		BEGIN;
 			SET @CheckSQL = N'';
-			SELECT @CheckSQL = @CheckSQL + 
+			SELECT @CheckSQL = @CheckSQL +
 				N'USE ' + QUOTENAME([database_name]) + N';
 				INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 				SELECT 	@CheckNumber
@@ -617,7 +617,7 @@ BEGIN
 			IF (@IsExpress = 1)
 				BEGIN;
 					SET @CheckSQL = N'';
-					SELECT @CheckSQL = @CheckSQL + 
+					SELECT @CheckSQL = @CheckSQL +
 						N'USE ' + QUOTENAME([database_name]) + N';
 						INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 						SELECT 	@CheckNumber
@@ -626,7 +626,7 @@ BEGIN
 								,QUOTENAME(DB_NAME())
 								,QUOTENAME(DB_NAME(database_id))
 								,NULL
-								,N''Database file '' + name + '' has a maximum growth set to '' + 
+								,N''Database file '' + name + '' has a maximum growth set to '' +
 									CASE
 										WHEN max_size = -1
 											THEN ''Unlimited''
@@ -685,7 +685,7 @@ BEGIN
 			IF(@IsExpress = 1)
 				BEGIN;
 					SET @CheckSQL = N'';
-					SELECT @CheckSQL = @CheckSQL + 
+					SELECT @CheckSQL = @CheckSQL +
 						N'USE ' + QUOTENAME([database_name]) + N';
 						INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 						SELECT 	@CheckNumber
@@ -717,7 +717,7 @@ BEGIN
 			END;
 		BEGIN;
 			SET @CheckSQL = N'';
-			SELECT @CheckSQL = @CheckSQL + 
+			SELECT @CheckSQL = @CheckSQL +
 				N'USE ' + QUOTENAME([database_name]) +  N';
 				INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 				SELECT 	@CheckNumber
@@ -750,7 +750,7 @@ BEGIN
 			END;
 		BEGIN;
 			SET @CheckSQL = N'';
-			SELECT @CheckSQL = @CheckSQL + 
+			SELECT @CheckSQL = @CheckSQL +
 				N' USE ? ;
 					BEGIN
 						IF OBJECT_ID(''tempdb..#Indexes'') IS NOT NULL
@@ -1067,9 +1067,9 @@ BEGIN
 							WHERE [sc].[stats_column_id] = 1
 								AND [s].[has_filter] = 0
 								AND [s].[no_recompute] = 0
-								AND [ac].[is_nullable] = 1 
+								AND [ac].[is_nullable] = 1
 								AND NOT EXISTS (SELECT 1 -- Compressed tables not compatible with sparse cols
-										FROM [sys].[partitions] AS [p]  
+										FROM [sys].[partitions] AS [p]
 										WHERE [p].[object_id] = [i].[object_id]
 											AND [p].[data_compression] > 0) ';
 			IF @HasTempStat = 1
@@ -1176,7 +1176,7 @@ BEGIN
 			END;
 		BEGIN
 			SET @CheckSQL = N'';
-			SELECT @CheckSQL = @CheckSQL + 
+			SELECT @CheckSQL = @CheckSQL +
 				N'USE ' + QUOTENAME([database_name]) + N';
 				INSERT INTO #results ([check_num], [check_type], [obj_type], [db_name], [obj_name], [col_name], [message], [ref_link])
 				SELECT 	@CheckNumber
@@ -1217,12 +1217,12 @@ BEGIN
 			DECLARE @ErrorState INT = ERROR_STATE();
 
 			RAISERROR(@ErrorMessage, @ErrorSeverity, @ErrorState) WITH NOWAIT;
-			SET @msg = CONCAT('Actual error number: ', @ErrorNumber);
-			RAISERROR(@msg, 16, 1);
-			SET @msg = CONCAT('Actual line number: ', @ErrorLine);
-			RAISERROR(@msg, 16, 1);
-			SET @msg = CONCAT('Check number: ', @CheckNumber);
-			RAISERROR(@msg, 16, 1);
+			SET @Msg = CONCAT('Actual error number: ', @ErrorNumber);
+			RAISERROR(@Msg, 16, 1);
+			SET @Msg = CONCAT('Actual line number: ', @ErrorLine);
+			RAISERROR(@Msg, 16, 1);
+			SET @Msg = CONCAT('Check number: ', @CheckNumber);
+			RAISERROR(@Msg, 16, 1);
 		END;
 	END CATCH;
 END;

appveyor/sqlcover/[dbo].[sp_sizeoptimiser]

@@ -72,13 +72,16 @@ EXEC dbo.sp_doc @DatabaseName = 'WideWorldImporters', @ExtendedPropertyName = 'M
 
 ### Output to File
 
-Batch:
+#### Batch
 
 ```batchfile
 sqlcmd -S localhost -d master -Q "exec sp_doc @DatabaseName = 'WideWorldImporters';" -o readme.md -y 0
 ```
 
-PowerShell / DbaTools:
+**Note:** The `-y 0` option is [important to specify][sqlcmd] so that variable length
+output is not capped at the default of 256 characters by sqlcmd.
+
+#### PowerShell / DbaTools
 
 ```powershell
 $Query = "EXEC sp_doc @DatabaseName = 'WideWorldImporters';"
@@ -143,4 +146,5 @@ Check out the other scripts in the [DBA MultiTool][tool].
 [issue]: https://github.com/LowlyDBA/dba-multitool/issues
 [sample]: assets/WideWorldImporters.md
 [so]: https://stackoverflow.com/a/37284582/4406684
+[sqlcmd]: https://docs.microsoft.com/en-us/sql/tools/sqlcmd-utility?view=sql-server-ver15#command-line-options
 [UVBug]: https://feedback.azure.com/forums/908035-sql-server/suggestions/32899324-ssms-ignores-final-r-n-crlf-carriage-return