Skip to content

Commit 386c0ee

Browse files
lowlydbalowlydba
authored
Development (#100)
* Sizeoptimiser 2012 features (#92) * Bring sp_sizeopt in line with other sprocs * sp_sizeoptimiser - clean up print statements * Automate installer script gen * Fix @isexpress setting * Reduce printing on sizeoptimiser - Move PS module installs to install step * Add token to appveyor for commits * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * test * Update appveyor.yml * Update appveyor.yml * Fix extraneous test output * Remove skipping output unless verbose * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Move appveyor to dir Co-authored-by: Your Name <Your email> Co-authored-by: John McCall <[email protected]> * Sizeoptimiser 2012 features (#92) (#93) (#95) * Bring sp_sizeopt in line with other sprocs * sp_sizeoptimiser - clean up print statements * Automate installer script gen * Fix @isexpress setting * Reduce printing on sizeoptimiser - Move PS module installs to install step * Add token to appveyor for commits * Move appveyor to dir * Fix sizeoptimiser short objname (#98) * increase obj name col Fixes #97 * Fix obj name on remaining temp tables * Update unit tests for obj name data type * Tsql lint (#99) * Create tsqllint.yml * Initial linting fixes * Update .gitignore * Delete tsqllint.yml * Move lint config * Add lint configs for each version * Remove npm install output to avoid error triggering * Update appveyor.yml * Fix unalias col refs * Missing comma in json * Try to fix weird npm error Only occurs sometimes...hoping a cache clear helps.. * Update appveyor.yml * Update appveyor.yml * Update appveyor.yml * Add explicit dev dependency * Fix env var for shell cmd * Delete tsqllint.yml Co-authored-by: John McCall <[email protected]>
1 parent 69903ea commit 386c0ee

File tree

15 files changed

+727
-214
lines changed

15 files changed

+727
-214
lines changed

‎.github/workflows/tsqllint.yml‎

Lines changed: 0 additions & 52 deletions
This file was deleted.

‎.gitignore‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
.markdownlint.json
1+
.markdownlint.json
2+
node_modules/*

‎appveyor/.tsqllintrc_110‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"rules": {
3+
"concat-strings": "error",
4+
"conditional-begin-end": "error",
5+
"cross-database-transaction": "error",
6+
"data-compression": "warn",
7+
"data-type-length": "error",
8+
"disallow-cursors": "off",
9+
"full-text": "error",
10+
"information-schema": "error",
11+
"keyword-capitalization": "error",
12+
"linked-server": "error",
13+
"multi-table-alias": "error",
14+
"non-sargable": "warn",
15+
"object-property": "error",
16+
"print-statement": "error",
17+
"schema-qualify": "error",
18+
"select-star": "error",
19+
"semicolon-termination": "error",
20+
"set-ansi": "error",
21+
"set-nocount": "error",
22+
"set-quoted-identifier": "error",
23+
"set-transaction-isolation-level": "off",
24+
"set-variable": "off",
25+
"upper-lower": "error"
26+
},
27+
"compatability-level": 110
28+
}

‎appveyor/.tsqllintrc_120‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"rules": {
3+
"concat-strings": "error",
4+
"conditional-begin-end": "error",
5+
"cross-database-transaction": "error",
6+
"data-compression": "warn",
7+
"data-type-length": "error",
8+
"disallow-cursors": "off",
9+
"full-text": "error",
10+
"information-schema": "error",
11+
"keyword-capitalization": "error",
12+
"linked-server": "error",
13+
"multi-table-alias": "error",
14+
"non-sargable": "warn",
15+
"object-property": "error",
16+
"print-statement": "error",
17+
"schema-qualify": "error",
18+
"select-star": "error",
19+
"semicolon-termination": "error",
20+
"set-ansi": "error",
21+
"set-nocount": "error",
22+
"set-quoted-identifier": "error",
23+
"set-transaction-isolation-level": "off",
24+
"set-variable": "off",
25+
"upper-lower": "error"
26+
},
27+
"compatability-level": 120
28+
}

‎appveyor/.tsqllintrc_130‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"rules": {
3+
"concat-strings": "error",
4+
"conditional-begin-end": "error",
5+
"cross-database-transaction": "error",
6+
"data-compression": "warn",
7+
"data-type-length": "error",
8+
"disallow-cursors": "off",
9+
"full-text": "error",
10+
"information-schema": "error",
11+
"keyword-capitalization": "error",
12+
"linked-server": "error",
13+
"multi-table-alias": "error",
14+
"non-sargable": "warn",
15+
"object-property": "error",
16+
"print-statement": "error",
17+
"schema-qualify": "error",
18+
"select-star": "error",
19+
"semicolon-termination": "error",
20+
"set-ansi": "error",
21+
"set-nocount": "error",
22+
"set-quoted-identifier": "error",
23+
"set-transaction-isolation-level": "off",
24+
"set-variable": "off",
25+
"upper-lower": "error"
26+
},
27+
"compatability-level": 130
28+
}

‎appveyor/.tsqllintrc_140‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"rules": {
3+
"concat-strings": "error",
4+
"conditional-begin-end": "error",
5+
"cross-database-transaction": "error",
6+
"data-compression": "warn",
7+
"data-type-length": "error",
8+
"disallow-cursors": "off",
9+
"full-text": "error",
10+
"information-schema": "error",
11+
"keyword-capitalization": "error",
12+
"linked-server": "error",
13+
"multi-table-alias": "error",
14+
"non-sargable": "warn",
15+
"object-property": "error",
16+
"print-statement": "error",
17+
"schema-qualify": "error",
18+
"select-star": "error",
19+
"semicolon-termination": "error",
20+
"set-ansi": "error",
21+
"set-nocount": "error",
22+
"set-quoted-identifier": "error",
23+
"set-transaction-isolation-level": "off",
24+
"set-variable": "off",
25+
"upper-lower": "error"
26+
},
27+
"compatability-level": 140
28+
}

‎appveyor/.tsqllintrc_150‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"rules": {
3+
"concat-strings": "error",
4+
"conditional-begin-end": "error",
5+
"cross-database-transaction": "error",
6+
"data-compression": "warn",
7+
"data-type-length": "error",
8+
"disallow-cursors": "off",
9+
"full-text": "error",
10+
"information-schema": "error",
11+
"keyword-capitalization": "error",
12+
"linked-server": "error",
13+
"multi-table-alias": "error",
14+
"non-sargable": "warn",
15+
"object-property": "error",
16+
"print-statement": "error",
17+
"schema-qualify": "error",
18+
"select-star": "error",
19+
"semicolon-termination": "error",
20+
"set-ansi": "error",
21+
"set-nocount": "error",
22+
"set-quoted-identifier": "error",
23+
"set-transaction-isolation-level": "off",
24+
"set-variable": "off",
25+
"upper-lower": "error"
26+
},
27+
"compatability-level": 150
28+
}

‎appveyor/appveyor.yml‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,25 +25,31 @@ environment:
2525
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
2626
MSSQL: SQL2019
2727
DB_INSTANCE: (local)\SQL2019
28+
LINT_CONFIG: appveyor\.tsqllintrc_150
2829

2930
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
3031
MSSQL: SQL2017
3132
DB_INSTANCE: (local)\SQL2017
33+
LINT_CONFIG: appveyor\.tsqllintrc_140
3234

3335
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
3436
MSSQL: SQL2016
3537
DB_INSTANCE: (local)\SQL2016
38+
LINT_CONFIG: appveyor\.tsqllintrc_130
3639

3740
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
3841
MSSQL: SQL2014
3942
DB_INSTANCE: (local)\SQL2014
43+
LINT_CONFIG: appveyor\.tsqllintrc_120
4044

4145
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
4246
MSSQL: SQL2012SP1
4347
DB_INSTANCE: (local)\SQL2012SP1
48+
LINT_CONFIG: appveyor/.tsqllintrc_110
4449

4550
install:
4651
- ps: Install-Module SqlServer -Force -AllowClobber
52+
- npm install
4753

4854
- echo Starting SQL Server
4955
- ps: >-
@@ -82,4 +88,7 @@ test_script:
8288
- ps: >-
8389
ForEach ($filename in Get-Childitem -Path $env:TSQLTTESTPATH -Filter "*.sql") {
8490
Invoke-SqlCmd –ServerInstance $env:DB_INSTANCE -Database $env:TARGET_DB -InputFile $filename.fullname -Username $env:MSSQL_LOGIN -Password $env:MSSQL_PASS -Verbose | Out-Null
85-
}
91+
}
92+
93+
- echo Running TSQLLint tests
94+
- npx tsqllint -c %LINT_CONFIG% *.sql

‎install_expsql.sql‎

-193 KB
Binary file not shown.

0 commit comments

Comments
 (0)