Skip to content

Commit 443f808

Browse files
authored
Merge pull request #244 from lowlydba/suggestion-fixes
Suggestion fixes
2 parents 731995c + 6bf4535 commit 443f808

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

install_dba-multitool.sql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3749,7 +3749,7 @@ sp_sizeoptimiser - Recommends space saving measures for data footprints.
37493749
37503750
Part of the DBA MultiTool http://dba-multitool.org
37513751
3752-
Version: 20220124
3752+
Version: 20220818
37533753
37543754
MIT License
37553755
@@ -4020,6 +4020,7 @@ BEGIN
40204020
AND ([c].[name] LIKE ''%date%'' OR [c].[name] LIKE ''%time%'')
40214021
AND [c].[name] NOT LIKE ''%UpdatedBy%''
40224022
AND [c].[name] NOT LIKE ''%days%''
4023+
AND ([c].[name] <> ''timestamp'' AND [ty].[name] NOT IN (''timestamp'', ''rowversion''))
40234024
AND [ty].[name] NOT IN (''datetime'', ''datetime2'', ''datetimeoffset'', ''date'', ''smalldatetime'', ''time'');'
40244025
FROM #Databases;
40254026
EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL;
@@ -4050,7 +4051,7 @@ BEGIN
40504051
UNION
40514052
SELECT QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name)
40524053
,QUOTENAME(c.name)
4053-
,N''Possible arbitrary variable length column in use. Is the '' + ty.name + N'' length of '' + CAST (c.max_length AS varchar(MAX)) + N'' based on requirements''
4054+
,N''Possible arbitrary variable length column in use. Is the '' + ty.name + N'' length of '' + CAST (c.max_length AS varchar(MAX)) + N'' based on requirements?''
40544055
,CONCAT(@BaseURL COLLATE database_default, ''arbitrary-varchar-length'')
40554056
FROM sys.columns as c
40564057
INNER JOIN sys.tables as t on t.object_id = c.object_id

sp_sizeoptimiser.sql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ sp_sizeoptimiser - Recommends space saving measures for data footprints.
124124
125125
Part of the DBA MultiTool http://dba-multitool.org
126126
127-
Version: 20220124
127+
Version: 20220818
128128
129129
MIT License
130130
@@ -395,6 +395,7 @@ BEGIN
395395
AND ([c].[name] LIKE ''%date%'' OR [c].[name] LIKE ''%time%'')
396396
AND [c].[name] NOT LIKE ''%UpdatedBy%''
397397
AND [c].[name] NOT LIKE ''%days%''
398+
AND ([c].[name] <> ''timestamp'' AND [ty].[name] NOT IN (''timestamp'', ''rowversion''))
398399
AND [ty].[name] NOT IN (''datetime'', ''datetime2'', ''datetimeoffset'', ''date'', ''smalldatetime'', ''time'');'
399400
FROM #Databases;
400401
EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL;
@@ -425,7 +426,7 @@ BEGIN
425426
UNION
426427
SELECT QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name)
427428
,QUOTENAME(c.name)
428-
,N''Possible arbitrary variable length column in use. Is the '' + ty.name + N'' length of '' + CAST (c.max_length AS varchar(MAX)) + N'' based on requirements''
429+
,N''Possible arbitrary variable length column in use. Is the '' + ty.name + N'' length of '' + CAST (c.max_length AS varchar(MAX)) + N'' based on requirements?''
429430
,CONCAT(@BaseURL COLLATE database_default, ''arbitrary-varchar-length'')
430431
FROM sys.columns as c
431432
INNER JOIN sys.tables as t on t.object_id = c.object_id

0 commit comments

Comments
 (0)