Skip to content

Commit 8a964f3

Browse files
author
Appveyor
committed
CI produced files
1 parent f07cf17 commit 8a964f3

File tree

3 files changed

+70
-76
lines changed

3 files changed

+70
-76
lines changed

‎appveyor/sqlcover/Coverage.opencoverxml‎

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -220,36 +220,36 @@
220220
<SequencePoint vc="5" uspid="208" ordinal="208" offset="41155" sl="1007" sc="3" el="1012" ec="29" />
221221
<SequencePoint vc="5" uspid="209" ordinal="209" offset="41413" sl="1015" sc="3" el="1027" ec="36" />
222222
<SequencePoint vc="5" uspid="210" ordinal="210" offset="41845" sl="1029" sc="3" el="1029" ec="59" />
223-
<SequencePoint vc="5" uspid="211" ordinal="211" offset="41909" sl="1031" sc="3" el="1074" ec="36" />
224-
<SequencePoint vc="5" uspid="212" ordinal="212" offset="44230" sl="1076" sc="3" el="1076" ec="22" />
225-
<SequencePoint vc="0" uspid="213" ordinal="213" offset="44268" sl="1078" sc="5" el="1078" ec="63" />
226-
<SequencePoint vc="5" uspid="214" ordinal="214" offset="44344" sl="1081" sc="3" el="1138" ec="10" />
227-
<SequencePoint vc="10" uspid="215" ordinal="215" offset="46482" sl="1140" sc="3" el="1142" ec="19" />
228-
<SequencePoint vc="0" uspid="216" ordinal="216" offset="46536" sl="1141" sc="7" el="1142" ec="19" />
229-
<SequencePoint vc="5" uspid="217" ordinal="217" offset="46598" sl="1144" sc="3" el="1144" ec="19" />
230-
<SequencePoint vc="5" uspid="218" ordinal="218" offset="46622" sl="1146" sc="3" el="1147" ec="15" />
231-
<SequencePoint vc="13" uspid="219" ordinal="219" offset="46717" sl="1150" sc="3" el="1150" ec="27" />
232-
<SequencePoint vc="8" uspid="220" ordinal="220" offset="46760" sl="1152" sc="5" el="1152" ec="58" />
233-
<SequencePoint vc="8" uspid="221" ordinal="221" offset="46821" sl="1153" sc="5" el="1153" ec="37" />
234-
<SequencePoint vc="8" uspid="222" ordinal="222" offset="46861" sl="1154" sc="5" el="1155" ec="17" />
235-
<SequencePoint vc="5" uspid="223" ordinal="223" offset="46923" sl="1157" sc="3" el="1157" ec="20" />
236-
<SequencePoint vc="5" uspid="224" ordinal="224" offset="46946" sl="1158" sc="3" el="1158" ec="25" />
237-
<SequencePoint vc="10" uspid="225" ordinal="225" offset="46976" sl="1160" sc="3" el="1170" ec="45" />
238-
<SequencePoint vc="5" uspid="226" ordinal="226" offset="47612" sl="1174" sc="2" el="1174" ec="37" />
239-
<SequencePoint vc="5" uspid="227" ordinal="227" offset="47652" sl="1175" sc="2" el="1175" ec="19" />
240-
<SequencePoint vc="1" uspid="228" ordinal="228" offset="47686" sl="1177" sc="4" el="1177" ec="64" />
241-
<SequencePoint vc="1" uspid="229" ordinal="229" offset="47753" sl="1178" sc="4" el="1178" ec="38" />
242-
<SequencePoint vc="5" uspid="230" ordinal="230" offset="47811" sl="1181" sc="3" el="1181" ec="22" />
243-
<SequencePoint vc="10" uspid="231" ordinal="231" offset="47836" sl="1182" sc="3" el="1196" ec="18" />
244-
<SequencePoint vc="5" uspid="232" ordinal="232" offset="48562" sl="1197" sc="3" el="1197" ec="130" />
245-
<SequencePoint vc="10" uspid="233" ordinal="233" offset="48738" sl="1201" sc="2" el="1210" ec="88" />
246-
<SequencePoint vc="4" uspid="234" ordinal="234" offset="49268" sl="1222" sc="3" el="1222" ec="68" />
247-
<SequencePoint vc="0" uspid="235" ordinal="235" offset="49339" sl="1223" sc="3" el="1223" ec="59" />
248-
<SequencePoint vc="0" uspid="236" ordinal="236" offset="49401" sl="1224" sc="3" el="1224" ec="25" />
249-
<SequencePoint vc="0" uspid="237" ordinal="237" offset="49429" sl="1225" sc="3" el="1225" ec="56" />
250-
<SequencePoint vc="0" uspid="238" ordinal="238" offset="49488" sl="1226" sc="3" el="1226" ec="25" />
251-
<SequencePoint vc="0" uspid="239" ordinal="239" offset="49516" sl="1227" sc="3" el="1227" ec="52" />
252-
<SequencePoint vc="0" uspid="240" ordinal="240" offset="49571" sl="1228" sc="3" el="1228" ec="25" />
223+
<SequencePoint vc="5" uspid="211" ordinal="211" offset="41909" sl="1031" sc="3" el="1074" ec="44" />
224+
<SequencePoint vc="5" uspid="212" ordinal="212" offset="44204" sl="1075" sc="3" el="1075" ec="22" />
225+
<SequencePoint vc="0" uspid="213" ordinal="213" offset="44242" sl="1077" sc="5" el="1077" ec="64" />
226+
<SequencePoint vc="5" uspid="214" ordinal="214" offset="44319" sl="1080" sc="3" el="1135" ec="10" />
227+
<SequencePoint vc="10" uspid="215" ordinal="215" offset="46312" sl="1137" sc="3" el="1139" ec="19" />
228+
<SequencePoint vc="0" uspid="216" ordinal="216" offset="46366" sl="1138" sc="7" el="1139" ec="19" />
229+
<SequencePoint vc="5" uspid="217" ordinal="217" offset="46428" sl="1141" sc="3" el="1141" ec="19" />
230+
<SequencePoint vc="5" uspid="218" ordinal="218" offset="46452" sl="1143" sc="3" el="1144" ec="15" />
231+
<SequencePoint vc="13" uspid="219" ordinal="219" offset="46547" sl="1147" sc="3" el="1147" ec="27" />
232+
<SequencePoint vc="8" uspid="220" ordinal="220" offset="46590" sl="1149" sc="5" el="1149" ec="58" />
233+
<SequencePoint vc="8" uspid="221" ordinal="221" offset="46651" sl="1150" sc="5" el="1150" ec="37" />
234+
<SequencePoint vc="8" uspid="222" ordinal="222" offset="46691" sl="1151" sc="5" el="1152" ec="17" />
235+
<SequencePoint vc="5" uspid="223" ordinal="223" offset="46753" sl="1154" sc="3" el="1154" ec="20" />
236+
<SequencePoint vc="5" uspid="224" ordinal="224" offset="46776" sl="1155" sc="3" el="1155" ec="25" />
237+
<SequencePoint vc="10" uspid="225" ordinal="225" offset="46806" sl="1157" sc="3" el="1167" ec="45" />
238+
<SequencePoint vc="5" uspid="226" ordinal="226" offset="47442" sl="1171" sc="2" el="1171" ec="37" />
239+
<SequencePoint vc="5" uspid="227" ordinal="227" offset="47482" sl="1172" sc="2" el="1172" ec="19" />
240+
<SequencePoint vc="1" uspid="228" ordinal="228" offset="47516" sl="1174" sc="4" el="1174" ec="64" />
241+
<SequencePoint vc="1" uspid="229" ordinal="229" offset="47583" sl="1175" sc="4" el="1175" ec="38" />
242+
<SequencePoint vc="5" uspid="230" ordinal="230" offset="47641" sl="1178" sc="3" el="1178" ec="22" />
243+
<SequencePoint vc="10" uspid="231" ordinal="231" offset="47666" sl="1179" sc="3" el="1193" ec="18" />
244+
<SequencePoint vc="5" uspid="232" ordinal="232" offset="48392" sl="1194" sc="3" el="1194" ec="130" />
245+
<SequencePoint vc="10" uspid="233" ordinal="233" offset="48568" sl="1198" sc="2" el="1207" ec="94" />
246+
<SequencePoint vc="4" uspid="234" ordinal="234" offset="49104" sl="1219" sc="3" el="1219" ec="68" />
247+
<SequencePoint vc="0" uspid="235" ordinal="235" offset="49175" sl="1220" sc="3" el="1220" ec="59" />
248+
<SequencePoint vc="0" uspid="236" ordinal="236" offset="49237" sl="1221" sc="3" el="1221" ec="25" />
249+
<SequencePoint vc="0" uspid="237" ordinal="237" offset="49265" sl="1222" sc="3" el="1222" ec="56" />
250+
<SequencePoint vc="0" uspid="238" ordinal="238" offset="49324" sl="1223" sc="3" el="1223" ec="25" />
251+
<SequencePoint vc="0" uspid="239" ordinal="239" offset="49352" sl="1224" sc="3" el="1224" ec="52" />
252+
<SequencePoint vc="0" uspid="240" ordinal="240" offset="49407" sl="1225" sc="3" el="1225" ec="25" />
253253
</SequencePoints>
254254
</Method>
255255
</Methods>

‎appveyor/sqlcover/[dbo].[sp_sizeoptimiser]‎

Lines changed: 20 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1032,10 +1032,10 @@ BEGIN
10321032
N' USE ?;
10331033
BEGIN
10341034
DECLARE @schemaName SYSNAME
1035-
,@tableName SYSNAME
1036-
,@statName SYSNAME
1037-
,@colName SYSNAME
1038-
,@threshold_null_perc SMALLINT;
1035+
,@tableName SYSNAME
1036+
,@statName SYSNAME
1037+
,@colName SYSNAME
1038+
,@threshold_null_perc SMALLINT;
10391039

10401040
DECLARE @DBCCSQL NVARCHAR(MAX) = N'''';
10411041
DECLARE @DBCCStatSQL NVARCHAR(MAX) = N'''';
@@ -1053,34 +1053,31 @@ BEGIN
10531053
INNER JOIN [sys].[tables] AS [t] on t.object_id = s.object_id
10541054
INNER JOIN [sys].[schemas] AS [sch] on sch.schema_id = t.schema_id
10551055
INNER JOIN [sys].[all_columns] AS [ac] on ac.column_id = sc.column_id
1056-
AND [ac].[object_id] = [t].[object_id]
1057-
AND [ac].[object_id] = [sc].[object_id]
1056+
AND [ac].[object_id] = [t].[object_id]
1057+
AND [ac].[object_id] = [sc].[object_id]
10581058
INNER JOIN [sys].[types] AS [typ] ON [typ].[user_type_id] = [ac].[user_type_id]
1059-
LEFT JOIN [sys].[indexes] AS [i] ON i.object_id = t.object_id
1060-
AND i.name = s.name
1061-
LEFT JOIN [sys].[index_columns] AS [ic] ON [ic].[object_id] = [i].[object_id]
1062-
AND [ic].[column_id] = [ac].[column_id]
1063-
AND ic.index_id = i.index_id '
1059+
INNER JOIN [sys].[indexes] AS [i] ON [i].[object_id] = [t].[object_id] '
10641060
+ /* Special considerations for variable length data types */ +
10651061
N'INNER JOIN [#SparseTypes] AS [st] ON [st].[user_type_id] = [typ].[user_type_id]
1066-
AND (typ.name NOT IN (''DECIMAL'', ''NUMERIC'', ''DATETIME2'', ''TIME'', ''DATETIMEOFFSET''))
1067-
OR (typ.name IN (''DECIMAL'', ''NUMERIC'') AND st.precision = ac.precision AND st.precision = 1)
1068-
OR (typ.name IN (''DECIMAL'', ''NUMERIC'') AND ac.precision > 1 AND st.precision = 38)
1069-
OR (typ.name IN (''DATETIME2'', ''TIME'', ''DATETIMEOFFSET'') AND st.scale = ac.scale AND st.scale = 0)
1070-
OR (typ.name IN (''DATETIME2'', ''TIME'', ''DATETIMEOFFSET'') AND ac.scale > 0 AND st.scale = 7)
1062+
AND (typ.name NOT IN (''DECIMAL'', ''NUMERIC'', ''DATETIME2'', ''TIME'', ''DATETIMEOFFSET''))
1063+
OR (typ.name IN (''DECIMAL'', ''NUMERIC'') AND st.precision = ac.precision AND st.precision = 1)
1064+
OR (typ.name IN (''DECIMAL'', ''NUMERIC'') AND ac.precision > 1 AND st.precision = 38)
1065+
OR (typ.name IN (''DATETIME2'', ''TIME'', ''DATETIMEOFFSET'') AND st.scale = ac.scale AND st.scale = 0)
1066+
OR (typ.name IN (''DATETIME2'', ''TIME'', ''DATETIMEOFFSET'') AND ac.scale > 0 AND st.scale = 7)
10711067
WHERE [sc].[stats_column_id] = 1
10721068
AND [s].[has_filter] = 0
10731069
AND [s].[no_recompute] = 0
1074-
AND [ac].[is_nullable] = 1 ';
1075-
1070+
AND [ac].[is_nullable] = 1
1071+
AND NOT EXISTS (SELECT 1 -- Compressed tables not compatible with sparse cols
1072+
FROM [sys].[partitions] AS [p]
1073+
WHERE [p].[object_id] = [i].[object_id]
1074+
AND [p].[data_compression] > 0) ';
10761075
IF @HasTempStat = 1
10771076
BEGIN;
1078-
SET @CheckSQL = @CheckSQL + N'AND [s].[is_temporary] = 0 ';
1077+
SET @CheckSQL = @CheckSQL + N'AND [s].[is_temporary] = 0; ';
10791078
END;
10801079

1081-
SET @CheckSQL = @CheckSQL + N'AND ([ic].[index_column_id] = 1 OR [ic].[index_column_id] IS NULL)
1082-
AND ([i].[type_desc] =''NONCLUSTERED'' OR [i].[type_desc] IS NULL);
1083-
1080+
SET @CheckSQL = @CheckSQL + N'
10841081
OPEN [DBCC_Cursor];
10851082

10861083
FETCH NEXT FROM [DBCC_Cursor]
@@ -1207,7 +1204,7 @@ BEGIN
12071204
,[message]
12081205
,[ref_link]
12091206
FROM #results
1210-
ORDER BY check_num, [check_type], [message], [db_name], obj_type, obj_name, [col_name];
1207+
ORDER BY [check_num], [check_type], [db_name], [obj_type], [obj_name], [col_name], [message];
12111208

12121209
END TRY
12131210

‎install_dba-multitool.sql‎

Lines changed: 20 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -3923,10 +3923,10 @@ BEGIN
39233923
N' USE ?;
39243924
BEGIN
39253925
DECLARE @schemaName SYSNAME
3926-
,@tableName SYSNAME
3927-
,@statName SYSNAME
3928-
,@colName SYSNAME
3929-
,@threshold_null_perc SMALLINT;
3926+
,@tableName SYSNAME
3927+
,@statName SYSNAME
3928+
,@colName SYSNAME
3929+
,@threshold_null_perc SMALLINT;
39303930
39313931
DECLARE @DBCCSQL NVARCHAR(MAX) = N'''';
39323932
DECLARE @DBCCStatSQL NVARCHAR(MAX) = N'''';
@@ -3944,34 +3944,31 @@ BEGIN
39443944
INNER JOIN [sys].[tables] AS [t] on t.object_id = s.object_id
39453945
INNER JOIN [sys].[schemas] AS [sch] on sch.schema_id = t.schema_id
39463946
INNER JOIN [sys].[all_columns] AS [ac] on ac.column_id = sc.column_id
3947-
AND [ac].[object_id] = [t].[object_id]
3948-
AND [ac].[object_id] = [sc].[object_id]
3947+
AND [ac].[object_id] = [t].[object_id]
3948+
AND [ac].[object_id] = [sc].[object_id]
39493949
INNER JOIN [sys].[types] AS [typ] ON [typ].[user_type_id] = [ac].[user_type_id]
3950-
LEFT JOIN [sys].[indexes] AS [i] ON i.object_id = t.object_id
3951-
AND i.name = s.name
3952-
LEFT JOIN [sys].[index_columns] AS [ic] ON [ic].[object_id] = [i].[object_id]
3953-
AND [ic].[column_id] = [ac].[column_id]
3954-
AND ic.index_id = i.index_id '
3950+
INNER JOIN [sys].[indexes] AS [i] ON [i].[object_id] = [t].[object_id] '
39553951
+ /* Special considerations for variable length data types */ +
39563952
N'INNER JOIN [#SparseTypes] AS [st] ON [st].[user_type_id] = [typ].[user_type_id]
3957-
AND (typ.name NOT IN (''DECIMAL'', ''NUMERIC'', ''DATETIME2'', ''TIME'', ''DATETIMEOFFSET''))
3958-
OR (typ.name IN (''DECIMAL'', ''NUMERIC'') AND st.precision = ac.precision AND st.precision = 1)
3959-
OR (typ.name IN (''DECIMAL'', ''NUMERIC'') AND ac.precision > 1 AND st.precision = 38)
3960-
OR (typ.name IN (''DATETIME2'', ''TIME'', ''DATETIMEOFFSET'') AND st.scale = ac.scale AND st.scale = 0)
3961-
OR (typ.name IN (''DATETIME2'', ''TIME'', ''DATETIMEOFFSET'') AND ac.scale > 0 AND st.scale = 7)
3953+
AND (typ.name NOT IN (''DECIMAL'', ''NUMERIC'', ''DATETIME2'', ''TIME'', ''DATETIMEOFFSET''))
3954+
OR (typ.name IN (''DECIMAL'', ''NUMERIC'') AND st.precision = ac.precision AND st.precision = 1)
3955+
OR (typ.name IN (''DECIMAL'', ''NUMERIC'') AND ac.precision > 1 AND st.precision = 38)
3956+
OR (typ.name IN (''DATETIME2'', ''TIME'', ''DATETIMEOFFSET'') AND st.scale = ac.scale AND st.scale = 0)
3957+
OR (typ.name IN (''DATETIME2'', ''TIME'', ''DATETIMEOFFSET'') AND ac.scale > 0 AND st.scale = 7)
39623958
WHERE [sc].[stats_column_id] = 1
39633959
AND [s].[has_filter] = 0
39643960
AND [s].[no_recompute] = 0
3965-
AND [ac].[is_nullable] = 1 ';
3966-
3961+
AND [ac].[is_nullable] = 1
3962+
AND NOT EXISTS (SELECT 1 -- Compressed tables not compatible with sparse cols
3963+
FROM [sys].[partitions] AS [p]
3964+
WHERE [p].[object_id] = [i].[object_id]
3965+
AND [p].[data_compression] > 0) ';
39673966
IF @HasTempStat = 1
39683967
BEGIN;
3969-
SET @CheckSQL = @CheckSQL + N'AND [s].[is_temporary] = 0 ';
3968+
SET @CheckSQL = @CheckSQL + N'AND [s].[is_temporary] = 0; ';
39703969
END;
39713970

3972-
SET @CheckSQL = @CheckSQL + N'AND ([ic].[index_column_id] = 1 OR [ic].[index_column_id] IS NULL)
3973-
AND ([i].[type_desc] =''NONCLUSTERED'' OR [i].[type_desc] IS NULL);
3974-
3971+
SET @CheckSQL = @CheckSQL + N'
39753972
OPEN [DBCC_Cursor];
39763973
39773974
FETCH NEXT FROM [DBCC_Cursor]
@@ -4098,7 +4095,7 @@ BEGIN
40984095
,[message]
40994096
,[ref_link]
41004097
FROM #results
4101-
ORDER BY check_num, [check_type], [message], [db_name], obj_type, obj_name, [col_name];
4098+
ORDER BY [check_num], [check_type], [db_name], [obj_type], [obj_name], [col_name], [message];
41024099

41034100
END TRY
41044101

0 commit comments

Comments
 (0)