Add sp_help code cov

Author: lowlydba

.gitignore

@@ -1,2 +1,3 @@
 .markdownlint.json
-node_modules/*
+node_modules/*
+package-lock.json

sp_helpme.sql

@@ -218,22 +218,22 @@ BEGIN
 
 		-- Data Type help (prec/scale only valid for numerics)
 		SET @SQLString = N'SELECT
-								[Type_name]			= t.name,
-								[Storage_type]		= type_name(system_type_id),
-								[Length]			= max_length,
-								[Prec]				= [precision],
-								[Scale]				= [scale],
-								[Nullable]			= case when is_nullable=1 then @Yes else @No end,
-								[Default_name]		= isnull(object_name(default_object_id), @None),
-								[Rule_name]			= isnull(object_name(rule_object_id), @None),
-								[Collation]			= collation_name,
-								[ExtendedProperty]	= ep.[value]
-							FROM [sys].[types] AS [t]
-								LEFT JOIN [sys].[extended_properties] AS [ep] ON [ep].[major_id] = [t].[user_type_id]
-									AND [ep].[name] = @epname
-									AND [ep].[minor_id] = 0
-									AND [ep].[class] = 6
-							WHERE [user_type_id] = @ObjID';
+						[Type_name]			= t.name,
+						[Storage_type]		= type_name(system_type_id),
+						[Length]			= max_length,
+						[Prec]				= [precision],
+						[Scale]				= [scale],
+						[Nullable]			= case when is_nullable=1 then @Yes else @No end,
+						[Default_name]		= isnull(object_name(default_object_id), @None),
+						[Rule_name]			= isnull(object_name(rule_object_id), @None),
+						[Collation]			= collation_name,
+						[ExtendedProperty]	= ep.[value]
+					FROM [sys].[types] AS [t]
+						LEFT JOIN [sys].[extended_properties] AS [ep] ON [ep].[major_id] = [t].[user_type_id]
+							AND [ep].[name] = @epname
+							AND [ep].[minor_id] = 0
+							AND [ep].[class] = 6
+					WHERE [user_type_id] = @ObjID';
 		SET @ParmDefinition = N'@ObjID INT, @Yes VARCHAR(5), @No VARCHAR(5), @None VARCHAR(5), @epname SYSNAME';
 
 		EXECUTE sp_executesql @SQLString

tests/build/sp_helpme_tests.sql

@@ -245,6 +245,52 @@ EXEC tSQLt.ResultSetFilter 0, @cmd; --Still runs but suppresses undesired output
 END;
 GO
 
+/*
+test that sp_helpme succeeds for a type
+*/
+CREATE PROCEDURE sp_helpme.[test sp succeeds for a type]
+AS
+BEGIN
+
+--Build
+DECLARE @Type SYSNAME = 'dbo.SizeOptimiserTableType';
+DECLARE @cmd NVARCHAR(MAX) = N'EXEC [sp_helpme] ''' + @Type + ''';';
+
+--Assert
+EXEC tSQLt.ExpectNoException;
+EXEC tSQLt.ResultSetFilter 0, @cmd; --Still runs but suppresses undesired output
+
+END;
+GO
+
+/*
+test that sp_helpme succeeds for a type
+*/
+CREATE PROCEDURE sp_helpme.[test sp succeeds for table with schemabound view]
+AS
+BEGIN
+
+--Build
+DECLARE @Table SYSNAME = 'tSQLt.CaptureOutputLog';
+DECLARE @cmd NVARCHAR(MAX) = N'EXEC [sp_helpme] ''' + @Table + ''';';
+DECLARE @sql NVARCHAR(MAX) = N'
+CREATE VIEW dbo.SchemaBoundView
+WITH SCHEMABINDING
+AS
+SELECT [id] FROM tSQLt.CaptureOutputLog;';
+
+IF EXISTS (SELECT * FROM sys.views WHERE object_id = OBJECT_ID(N'dbo.SchemaBoundView'))
+    DROP VIEW dbo.SchemaBoundView;
+
+EXEC sp_executesql @sql;
+
+--Assert
+EXEC tSQLt.ExpectNoException;
+EXEC tSQLt.ResultSetFilter 0, @cmd; --Still runs but suppresses undesired output
+
+END;
+GO
+
 /************************************
 End sp_helpme tests
 *************************************/

tests/run/localdev_test.ps1

@@ -5,12 +5,18 @@ $TrustedConnection = "yes"
 $TestPath = "tests\run"
 $TestBuildPath = "tests\build"
 
+# Install TSQLLint
+npm install tsqllint -g
 
 # Install latest versions
 Write-Host "Installing scripts..."
-Invoke-Sqlcmd -ServerInstance $SqlInstance -Database $Database -InputFile "sp_doc.sql"
-Invoke-Sqlcmd -ServerInstance $SqlInstance -Database $Database -InputFile "sp_helpme.sql"
-Invoke-Sqlcmd -ServerInstance $SqlInstance -Database $Database -InputFile "sp_sizeoptimiser.sql"
+ForEach ($filename in Get-Childitem -Filter "*.sql") {
+    Invoke-SqlCmd -ServerInstance $SqlInstance -Database $Database -InputFile $filename.fullname -Verbose | Out-Null
+}
+
+# Lint code 
+Write-Host "Linting scripts..."
+tsqllint *.sql
 
 # Install tests
 Write-Host "Installing tSQLt Tests..."