-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
application-serverSpring Boot server: APIs, business logic, databaseSpring Boot server: APIs, business logic, database
Milestone
Description
Context
Found during PE audit of PR #892. Several security-critical code paths lack dedicated tests:
SandboxWorkspaceManager.validateDirectoryMount()— path traversal preventionAgentJobService.retryDelivery()— retry logic for failed deliveriesUNSAFE_MARKDOWN_LINKregex inPullRequestCommentPoster— XSS prevention in PR comments- Git security env vars in
DockerSandboxAdapter— config blocklist
Scope
Write focused unit tests for each of the 4 paths:
- Path traversal: symlinks,
../sequences, absolute paths outside allowed root - Retry: idempotency, max retries, state transitions
- Markdown sanitization: malicious links, JS injection, nested markdown
- Git env vars: verify all blocked configs present in container env
Files
| File | Change |
|---|---|
SandboxWorkspaceManagerTest.java |
NEW or MODIFY |
AgentJobServiceTest.java |
NEW or MODIFY |
PullRequestCommentPosterTest.java |
NEW or MODIFY |
DockerSandboxAdapterTest.java |
NEW or MODIFY |
Verification
- All 4 test classes pass
- Path traversal attacks caught by
validateDirectoryMount() - Unsafe markdown sanitized correctly
- Git config blocklist verified exhaustively
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
application-serverSpring Boot server: APIs, business logic, databaseSpring Boot server: APIs, business logic, database