refactor: make it more generic

Author: lsfratel

tests/core/test_wsgi.py

@@ -216,8 +216,7 @@ def handle_get(self, request):
     response_body = b"".join(response_iter).decode()
 
     assert start_response.status.startswith("418 I'm a teapot")
-    assert '"code":"I_AM_A_TEAPOT"' in response_body
-    assert '"message":"Test error"' in response_body
+    assert 'Test error' in response_body
 
 
 def test_custom_exception_handler():

tests/http/test_response.py

@@ -9,7 +9,6 @@
     RedirectResponse,
     Response,
     StreamResponse,
-    SuccessResponse,
     TextResponse,
 )
 from webspark.utils.exceptions import HTTPException
@@ -269,19 +268,6 @@ def test_stream_response_as_wsgi():
     assert body_iter == [content]
 
 
-def test_success_response():
-    data = {"id": 1, "name": "Test"}
-    response = SuccessResponse(data, status=201)
-
-    assert isinstance(response, JsonResponse)
-    assert response.status == 201
-    assert response.headers["content-type"] == "application/json; charset=utf-8"
-
-    body_bytes = response._body_bytes
-    decoded_data = json.loads(body_bytes.decode("utf-8"))
-    assert decoded_data == {"success": True, "data": data}
-
-
 def test_response_as_wsgi_with_unknown_status():
     response = Response(body="Hello, World!", status=299)
     status_str, headers_list, body_iter = response.as_wsgi()

webspark/constants.py

@@ -24,6 +24,7 @@
     101: "101 Switching Protocols",
     102: "102 Processing",
     103: "103 Early Hints",
+
     # 2xx: Success
     200: "200 OK",
     201: "201 Created",
@@ -35,6 +36,7 @@
     207: "207 Multi-Status",
     208: "208 Already Reported",
     226: "226 IM Used",
+
     # 3xx: Redirection
     300: "300 Multiple Choices",
     301: "301 Moved Permanently",
@@ -44,6 +46,7 @@
     305: "305 Use Proxy",
     307: "307 Temporary Redirect",
     308: "308 Permanent Redirect",
+
     # 4xx: Client Error
     400: "400 Bad Request",
     401: "401 Unauthorized",
@@ -74,6 +77,7 @@
     429: "429 Too Many Requests",
     431: "431 Request Header Fields Too Large",
     451: "451 Unavailable For Legal Reasons",
+
     # 5xx: Server Error
     500: "500 Internal Server Error",
     501: "501 Not Implemented",
@@ -87,84 +91,3 @@
     510: "510 Not Extended",
     511: "511 Network Authentication Required",
 }
-
-ERROR_CONVENTIONS = {
-    # 4xx — Client Errors
-    400: {"code": "BAD_REQUEST", "message": "Invalid request."},
-    401: {"code": "UNAUTHORIZED", "message": "Authentication required or invalid."},
-    402: {"code": "PAYMENT_REQUIRED", "message": "Payment required."},
-    403: {
-        "code": "FORBIDDEN",
-        "message": "You do not have permission to perform this action.",
-    },
-    404: {"code": "NOT_FOUND", "message": "Resource not found."},
-    405: {
-        "code": "METHOD_NOT_ALLOWED",
-        "message": "HTTP method not allowed for this resource.",
-    },
-    406: {"code": "NOT_ACCEPTABLE", "message": "Response format not acceptable."},
-    407: {
-        "code": "PROXY_AUTH_REQUIRED",
-        "message": "Proxy authentication is required.",
-    },
-    408: {"code": "REQUEST_TIMEOUT", "message": "Request timed out."},
-    409: {
-        "code": "CONFLICT",
-        "message": "Conflict with the current state of the resource.",
-    },
-    410: {"code": "GONE", "message": "Resource is no longer available."},
-    411: {"code": "LENGTH_REQUIRED", "message": "Content-Length header is required."},
-    412: {"code": "PRECONDITION_FAILED", "message": "Preconditions not met."},
-    413: {"code": "PAYLOAD_TOO_LARGE", "message": "Payload too large."},
-    414: {"code": "URI_TOO_LONG", "message": "URI too long."},
-    415: {"code": "UNSUPPORTED_MEDIA_TYPE", "message": "Unsupported media type."},
-    416: {"code": "RANGE_NOT_SATISFIABLE", "message": "Byte range not satisfiable."},
-    417: {
-        "code": "EXPECTATION_FAILED",
-        "message": "Expectation in header could not be met.",
-    },
-    418: {"code": "I_AM_A_TEAPOT", "message": "I am a teapot."},
-    421: {
-        "code": "MISDIRECTED_REQUEST",
-        "message": "Request directed to the wrong server.",
-    },
-    422: {"code": "UNPROCESSABLE_ENTITY", "message": "Invalid semantic entity."},
-    423: {"code": "LOCKED", "message": "Resource locked."},
-    424: {"code": "FAILED_DEPENDENCY", "message": "Failed dependency."},
-    425: {"code": "TOO_EARLY", "message": "Too early to process; try again."},
-    426: {"code": "UPGRADE_REQUIRED", "message": "Protocol upgrade required."},
-    428: {"code": "PRECONDITION_REQUIRED", "message": "Precondition required."},
-    429: {
-        "code": "TOO_MANY_REQUESTS",
-        "message": "Too many requests; try again later.",
-    },
-    431: {
-        "code": "REQUEST_HEADER_FIELDS_TOO_LARGE",
-        "message": "Request header fields too large.",
-    },
-    451: {
-        "code": "UNAVAILABLE_FOR_LEGAL_REASONS",
-        "message": "Unavailable for legal reasons.",
-    },
-    # 5xx — Server Errors
-    500: {"code": "INTERNAL_ERROR", "message": "Internal error. Please try again."},
-    501: {"code": "NOT_IMPLEMENTED", "message": "Functionality not implemented."},
-    502: {"code": "BAD_GATEWAY", "message": "Bad gateway."},
-    503: {
-        "code": "SERVICE_UNAVAILABLE",
-        "message": "Service unavailable. Please try again later.",
-    },
-    504: {"code": "GATEWAY_TIMEOUT", "message": "Gateway timeout."},
-    505: {
-        "code": "HTTP_VERSION_NOT_SUPPORTED",
-        "message": "HTTP version not supported.",
-    },
-    506: {"code": "VARIANT_ALSO_NEGOTIATES", "message": "Content negotiation failed."},
-    507: {"code": "INSUFFICIENT_STORAGE", "message": "Insufficient storage."},
-    508: {"code": "LOOP_DETECTED", "message": "Loop detected during processing."},
-    510: {"code": "NOT_EXTENDED", "message": "Policy extensions required."},
-    511: {
-        "code": "NETWORK_AUTH_REQUIRED",
-        "message": "Network authentication required.",
-    },
-}

webspark/core/wsgi.py

@@ -9,9 +9,8 @@
     from .plugin import Plugin
     from .router import path
 
-from ..constants import ERROR_CONVENTIONS
 from ..http.request import Request
-from ..http.response import JsonResponse, Response
+from ..http.response import Response, TextResponse
 from ..utils import HTTPException
 from .router import Router
 
@@ -206,41 +205,10 @@ def check_allowed_hosts(self, request: Request):
         raise HTTPException(f"Host '{host}' not allowed.", status_code=400)
 
     def default_exception_handler(self, _: Request, exc: Exception):
-        """Default exception handler for unhandled exceptions.
-
-        This method generates a standardized JSON error response for any
-        unhandled exceptions that occur during request processing. It uses
-        the framework's error conventions to provide consistent error messages.
-
-        Args:
-            _: Request object (unused).
-            exc: Exception that occurred.
-
-        Returns:
-            JsonResponse: Standardized error response.
-        """
-        status_code = getattr(exc, "status_code", 500)
-        details = getattr(exc, "details", None)
-
-        base = ERROR_CONVENTIONS.get(
-            status_code,
-            {"code": "UNKNOWN_ERROR", "message": "An unknown error occurred."},
-        )
-
-        error = {"code": base["code"], "message": base["message"]}
-
-        if details:
-            if isinstance(details, dict):
-                error["details"] = details
-            else:
-                error["message"] = details
-
-        return JsonResponse(
-            {
-                "success": False,
-                "error": error,
-            },
-            status=status_code,
+        message = getattr(exc, "details", "Internal error. Please try again.")
+        satus = getattr(exc, "status_code", 400)
+        return TextResponse(
+            str(message) if not isinstance(message, str) else message, status=satus
         )
 
     def dispatch_request(self, request: Request):

webspark/http/__init__.py

@@ -6,7 +6,6 @@
     RedirectResponse,
     Response,
     StreamResponse,
-    SuccessResponse,
     TextResponse,
 )
 
@@ -17,7 +16,6 @@
     "HTMLResponse",
     "MultipartParser",
     "StreamResponse",
-    "SuccessResponse",
     "TextResponse",
     "RedirectResponse",
 ]

webspark/http/response.py

@@ -575,33 +575,3 @@ def as_wsgi(self):
         status_str = STATUS_CODE.get(self.status, f"{self.status} Unknown")
         headers_list = list(self.headers.items())
         return status_str, headers_list, self.body
-
-
-def SuccessResponse(
-    data: Any, status: int = 200, headers: dict[str, str] | None = None
-) -> JsonResponse:
-    """Create a standardized success JSON response.
-
-    This utility function creates a JsonResponse with a standardized
-    success format that includes a success flag and wrapped data.
-
-    Example:
-        response = SuccessResponse({"user_id": 123, "username": "john_doe"})
-        # Creates JSON: {"success": true, "data": {"user_id": 123, "username": "john_doe"}}
-
-    Args:
-        data: The data to wrap in the success response.
-        status: HTTP status code (default: 200).
-        headers: Additional headers.
-
-    Returns:
-        JsonResponse: A JSON response with success structure.
-    """
-    return JsonResponse(
-        {
-            "success": True,
-            "data": data,
-        },
-        status=status,
-        headers=headers,
-    )