Fix LSP client capability declarations to match server implementations

- Update all clients to correctly declare supported capabilities
- Add missing inlay hint and signature help support where servers provide it
- Remove unsupported diagnostic capabilities from clients
- Add comprehensive capability support to DenoClient
- Ensure client-server capability alignment for reliable LSP communication

Author: observerw

src/lsp_client/clients/__init__.py

@@ -1,5 +1,8 @@
 from __future__ import annotations
 
+from typing import Final
+
+from .deno import DenoClient
 from .gopls import GoplsClient
 from .pyrefly import PyreflyClient
 from .pyright import PyrightClient
@@ -11,11 +14,22 @@
 RustClient = RustAnalyzerClient
 TypeScriptClient = TypescriptClient
 
+clients: Final = (
+    GoplsClient,
+    PyreflyClient,
+    PyrightClient,
+    RustAnalyzerClient,
+    DenoClient,
+    TypescriptClient,
+)
+
 __all__ = [
+    "DenoClient",
     "GoClient",
     "GoplsClient",
     "PyreflyClient",
     "PythonClient",
     "RustClient",
     "TypeScriptClient",
+    "client",
 ]

src/lsp_client/clients/deno/client.py

@@ -9,22 +9,36 @@
 from attrs import Factory, define
 from loguru import logger
 
+from lsp_client.capability.notification import (
+    WithNotifyDidChangeConfiguration,
+)
 from lsp_client.capability.request import (
     WithRequestCallHierarchy,
     WithRequestCompletion,
     WithRequestDefinition,
     WithRequestDocumentSymbol,
     WithRequestHover,
     WithRequestImplementation,
+    WithRequestInlayHint,
     WithRequestPullDiagnostic,
     WithRequestReferences,
+    WithRequestSignatureHelp,
     WithRequestTypeDefinition,
     WithRequestWorkspaceSymbol,
 )
 from lsp_client.capability.server_notification import (
+    WithReceiveLogTrace,
     WithReceivePublishDiagnostics,
+    WithReceiveShowMessage,
 )
 from lsp_client.capability.server_notification.log_message import WithReceiveLogMessage
+from lsp_client.capability.server_request import (
+    WithRespondConfigurationRequest,
+    WithRespondInlayHintRefresh,
+    WithRespondShowDocumentRequest,
+    WithRespondShowMessageRequest,
+    WithRespondWorkspaceFoldersRequest,
+)
 from lsp_client.client.abc import Client
 from lsp_client.server import DefaultServers, ServerInstallationError
 from lsp_client.server.container import ContainerServer
@@ -80,6 +94,7 @@ async def ensure_deno_installed() -> None:
 @define
 class DenoClient(
     Client,
+    WithNotifyDidChangeConfiguration,
     WithRequestHover,
     WithRequestCompletion,
     WithRequestDefinition,
@@ -88,10 +103,19 @@ class DenoClient(
     WithRequestTypeDefinition,
     WithRequestCallHierarchy,
     WithRequestDocumentSymbol,
+    WithRequestInlayHint,
     WithRequestPullDiagnostic,
+    WithRequestSignatureHelp,
     WithRequestWorkspaceSymbol,
     WithReceiveLogMessage,
+    WithReceiveLogTrace,
     WithReceivePublishDiagnostics,
+    WithReceiveShowMessage,
+    WithRespondConfigurationRequest,
+    WithRespondInlayHintRefresh,
+    WithRespondShowDocumentRequest,
+    WithRespondShowMessageRequest,
+    WithRespondWorkspaceFoldersRequest,
     WithRequestDenoCache,
     WithRequestDenoPerformance,
     WithRequestDenoReloadImportRegistries,

src/lsp_client/clients/gopls.py

@@ -41,9 +41,7 @@
 from lsp_client.server.local import LocalServer
 from lsp_client.utils.types import lsp_type
 
-GoplsContainerServer = partial(
-    ContainerServer, image="ghcr.io/observerw/lsp-client/gopls:latest"
-)
+GoplsContainerServer = partial(ContainerServer, image="ghcr.io/lsp-client/gopls:latest")
 
 
 async def ensure_gopls_installed() -> None:

src/lsp_client/clients/pyrefly.py

@@ -20,8 +20,9 @@
     WithRequestDocumentSymbol,
     WithRequestHover,
     WithRequestImplementation,
-    WithRequestPullDiagnostic,
+    WithRequestInlayHint,
     WithRequestReferences,
+    WithRequestSignatureHelp,
     WithRequestTypeDefinition,
     WithRequestWorkspaceSymbol,
 )
@@ -33,6 +34,7 @@
 )
 from lsp_client.capability.server_request import (
     WithRespondConfigurationRequest,
+    WithRespondInlayHintRefresh,
     WithRespondShowDocumentRequest,
     WithRespondShowMessageRequest,
     WithRespondWorkspaceFoldersRequest,
@@ -87,15 +89,17 @@ class PyreflyClient(
     WithRequestDocumentSymbol,
     WithRequestHover,
     WithRequestImplementation,
-    WithRequestPullDiagnostic,
+    WithRequestInlayHint,
     WithRequestReferences,
+    WithRequestSignatureHelp,
     WithRequestTypeDefinition,
     WithRequestWorkspaceSymbol,
     WithReceiveLogMessage,
     WithReceiveLogTrace,
     WithReceivePublishDiagnostics,
     WithReceiveShowMessage,
     WithRespondConfigurationRequest,
+    WithRespondInlayHintRefresh,
     WithRespondShowDocumentRequest,
     WithRespondShowMessageRequest,
     WithRespondWorkspaceFoldersRequest,

src/lsp_client/clients/pyright.py

@@ -19,8 +19,8 @@
     WithRequestDefinition,
     WithRequestDocumentSymbol,
     WithRequestHover,
-    WithRequestPullDiagnostic,
     WithRequestReferences,
+    WithRequestSignatureHelp,
     WithRequestTypeDefinition,
     WithRequestWorkspaceSymbol,
 )
@@ -32,6 +32,7 @@
 )
 from lsp_client.capability.server_request import (
     WithRespondConfigurationRequest,
+    WithRespondInlayHintRefresh,
     WithRespondShowDocumentRequest,
     WithRespondShowMessageRequest,
     WithRespondWorkspaceFoldersRequest,
@@ -82,15 +83,16 @@ class PyrightClient(
     WithRequestDefinition,
     WithRequestDocumentSymbol,
     WithRequestHover,
-    WithRequestPullDiagnostic,
     WithRequestReferences,
+    WithRequestSignatureHelp,
     WithRequestTypeDefinition,
     WithRequestWorkspaceSymbol,
     WithReceiveLogMessage,
     WithReceiveLogTrace,
     WithReceivePublishDiagnostics,
     WithReceiveShowMessage,
     WithRespondConfigurationRequest,
+    WithRespondInlayHintRefresh,
     WithRespondShowDocumentRequest,
     WithRespondShowMessageRequest,
     WithRespondWorkspaceFoldersRequest,

src/lsp_client/clients/rust_analyzer.py

@@ -20,8 +20,10 @@
     WithRequestDocumentSymbol,
     WithRequestHover,
     WithRequestImplementation,
+    WithRequestInlayHint,
     WithRequestPullDiagnostic,
     WithRequestReferences,
+    WithRequestSignatureHelp,
     WithRequestTypeDefinition,
     WithRequestWorkspaceSymbol,
 )
@@ -33,6 +35,7 @@
 )
 from lsp_client.capability.server_request import (
     WithRespondConfigurationRequest,
+    WithRespondInlayHintRefresh,
     WithRespondShowDocumentRequest,
     WithRespondShowMessageRequest,
     WithRespondWorkspaceFoldersRequest,
@@ -83,15 +86,18 @@ class RustAnalyzerClient(
     WithRequestDocumentSymbol,
     WithRequestHover,
     WithRequestImplementation,
+    WithRequestInlayHint,
     WithRequestPullDiagnostic,
     WithRequestReferences,
+    WithRequestSignatureHelp,
     WithRequestTypeDefinition,
     WithRequestWorkspaceSymbol,
     WithReceiveLogMessage,
     WithReceiveLogTrace,
     WithReceivePublishDiagnostics,
     WithReceiveShowMessage,
     WithRespondConfigurationRequest,
+    WithRespondInlayHintRefresh,
     WithRespondShowDocumentRequest,
     WithRespondShowMessageRequest,
     WithRespondWorkspaceFoldersRequest,

src/lsp_client/clients/typescript.py

@@ -18,8 +18,9 @@
     WithRequestDocumentSymbol,
     WithRequestHover,
     WithRequestImplementation,
-    WithRequestPullDiagnostic,
+    WithRequestInlayHint,
     WithRequestReferences,
+    WithRequestSignatureHelp,
     WithRequestTypeDefinition,
     WithRequestWorkspaceSymbol,
 )
@@ -31,6 +32,7 @@
 from lsp_client.capability.server_notification.log_message import WithReceiveLogMessage
 from lsp_client.capability.server_request import (
     WithRespondConfigurationRequest,
+    WithRespondInlayHintRefresh,
     WithRespondShowDocumentRequest,
     WithRespondShowMessageRequest,
     WithRespondWorkspaceFoldersRequest,
@@ -88,13 +90,15 @@ class TypescriptClient(
     WithRequestImplementation,
     WithRequestTypeDefinition,
     WithRequestDocumentSymbol,
-    WithRequestPullDiagnostic,
+    WithRequestInlayHint,
+    WithRequestSignatureHelp,
     WithRequestWorkspaceSymbol,
     WithReceiveLogMessage,
     WithReceiveLogTrace,
     WithReceivePublishDiagnostics,
     WithReceiveShowMessage,
     WithRespondConfigurationRequest,
+    WithRespondInlayHintRefresh,
     WithRespondShowDocumentRequest,
     WithRespondShowMessageRequest,
     WithRespondWorkspaceFoldersRequest,

tests/test_inspect_clients.py

@@ -0,0 +1,49 @@
+from __future__ import annotations
+
+import shutil
+import subprocess
+
+import pytest
+
+from lsp_client.clients import clients
+from lsp_client.utils.inspect import inspect_capabilities
+
+
+def has_docker() -> bool:
+    if not shutil.which("docker"):
+        return False
+    try:
+        subprocess.run(["docker", "info"], check=True, capture_output=True)
+        return True
+    except (subprocess.CalledProcessError, FileNotFoundError):
+        return False
+
+
+@pytest.mark.skipif(not has_docker(), reason="Docker not available")
+@pytest.mark.asyncio
+@pytest.mark.parametrize("client_cls", clients)
+async def test_client_capabilities_match_container(client_cls):
+    client = client_cls()
+    servers = client.create_default_servers()
+    server = servers.container
+
+    if server is None:
+        pytest.skip(f"No container server defined for {client_cls.__name__}")
+
+    mismatches = []
+    async for result in inspect_capabilities(server, client_cls):
+        # We only care about capabilities that the client CLAIMS to support but the server doesn't,
+        # or vice versa (though usually we care more about the client expecting something the server doesn't provide)
+        if result.client != result.server:
+            mismatches.append(
+                f"{result.capability}: client={result.client}, server={result.server}"
+            )
+
+    if mismatches:
+        # For now, let's just log them or fail if we want strict matching.
+        # The user asked to "detect", so failing on mismatch is a good way to ensure they stay in sync.
+        # However, some servers might legitimately not support some things that we've implemented in the client (maybe for newer versions).
+        # But usually they should match if we are targeting a specific version in the container.
+        pytest.fail(
+            f"Capability mismatch for {client_cls.__name__}:\n" + "\n".join(mismatches)
+        )