feat(client): implement default server factory for LSP clients

Author: observerw

src/lsp_client/client/abc.py

@@ -10,7 +10,7 @@
 import anyio
 import asyncer
 from anyio import AsyncContextManagerMixin
-from attrs import define, field
+from attrs import Factory, define, field
 from loguru import logger
 
 from lsp_client.capability.build import (
@@ -51,7 +51,10 @@ class LSPClient(
     AsyncContextManagerMixin,
     ABC,
 ):
-    _server: LSPServer = field(alias="server")
+    _server: LSPServer = field(
+        alias="server",
+        default=Factory(lambda self: self.create_default_server(), takes_self=True),
+    )
 
     _workspace: RawWorkspace = field(alias="workspace", factory=Path.cwd)
     sync_file: bool = True
@@ -87,6 +90,10 @@ def get_workspace(self) -> Workspace:
     def get_language_id(self) -> lsp_type.LanguageKind:
         """The language ID of the client."""
 
+    @abstractmethod
+    def create_default_server(self) -> LSPServer:
+        """Create the default server for this client."""
+
     @abstractmethod
     async def ensure_installed(self) -> None:
         """

src/lsp_client/clients/__init__.py

@@ -7,10 +7,10 @@
 from .rust_analyzer import RustAnalyzerClient
 from .typescript import TypescriptClient
 
-clients: Final = (
-    PyreflyClient,
+local_clients: Final = (
     PyrightClient,
     RustAnalyzerClient,
+    PyreflyClient,
     TypescriptClient,
 )
 
@@ -22,5 +22,5 @@
     "PythonClient",
     "RustClient",
     "TypeScriptClient",
-    "clients",
+    "local_clients",
 ]

src/lsp_client/clients/pyrefly.py

@@ -36,10 +36,14 @@
     WithRespondWorkspaceFoldersRequest,
 )
 from lsp_client.client.abc import LSPClient
+from lsp_client.server.abc import LSPServer
+from lsp_client.server.docker import DockerServer
 from lsp_client.server.local import LocalServer
 from lsp_client.utils.types import lsp_type
 
-PyreflyLocalServer = partial(LocalServer, command=["pyrefly", "lsp"])
+PyreflyDockerServer = partial(
+    DockerServer, image="docker.io/lspcontainers/pyrefly"
+)
 
 
 @define
@@ -82,6 +86,10 @@ class PyreflyClient(
     def get_language_id(self) -> lsp_type.LanguageKind:
         return lsp_type.LanguageKind.Python
 
+    @override
+    def create_default_server(self) -> LSPServer:
+        return LocalServer(command=["pyrefly", "lsp"])
+
     @override
     def create_initialization_options(self) -> dict[str, Any]:
         options: dict[str, Any] = {}

src/lsp_client/clients/pyright.py

@@ -35,11 +35,11 @@
     WithRespondWorkspaceFoldersRequest,
 )
 from lsp_client.client.abc import LSPClient
+from lsp_client.server.abc import LSPServer
 from lsp_client.server.docker import DockerServer
 from lsp_client.server.local import LocalServer
 from lsp_client.utils.types import lsp_type
 
-PyrightLocalServer = partial(LocalServer, command=["pyright-langserver", "--stdio"])
 PyrightDockerServer = partial(
     DockerServer, image="docker.io/lspcontainers/pyright-langserver"
 )
@@ -81,6 +81,10 @@ class PyrightClient(
     def get_language_id(self) -> lsp_type.LanguageKind:
         return lsp_type.LanguageKind.Python
 
+    @override
+    def create_default_server(self) -> LSPServer:
+        return LocalServer(command=["pyright-langserver", "--stdio"])
+
     @override
     def create_initialization_options(self) -> dict[str, Any]:
         return {

src/lsp_client/clients/rust_analyzer.py

@@ -36,11 +36,11 @@
     WithRespondWorkspaceFoldersRequest,
 )
 from lsp_client.client.abc import LSPClient
+from lsp_client.server.abc import LSPServer
 from lsp_client.server.docker import DockerServer
 from lsp_client.server.local import LocalServer
 from lsp_client.utils.types import lsp_type
 
-RustAnalyzerLocalServer = partial(LocalServer, command=["rust-analyzer"])
 RustAnalyzerDockerServer = partial(
     DockerServer, image="docker.io/lspcontainers/rust-analyzer"
 )
@@ -86,6 +86,10 @@ class RustAnalyzerClient(
     def get_language_id(self) -> lsp_type.LanguageKind:
         return lsp_type.LanguageKind.Rust
 
+    @override
+    def create_default_server(self) -> LSPServer:
+        return LocalServer(command=["rust-analyzer"])
+
     @override
     def create_initialization_options(self) -> dict[str, Any]:
         return {

src/lsp_client/clients/typescript.py

@@ -34,13 +34,11 @@
     WithRespondWorkspaceFoldersRequest,
 )
 from lsp_client.client.abc import LSPClient
+from lsp_client.server.abc import LSPServer
 from lsp_client.server.docker import DockerServer
 from lsp_client.server.local import LocalServer
 from lsp_client.utils.types import lsp_type
 
-TypescriptServer = partial(
-    LocalServer, command=["typescript-language-server", "--stdio"]
-)
 TypescriptDockerServer = partial(DockerServer, image="docker.io/lspcontainers/tsserver")
 
 
@@ -83,6 +81,10 @@ class TypescriptClient(
     def get_language_id(self) -> lsp_type.LanguageKind:
         return lsp_type.LanguageKind.TypeScript
 
+    @override
+    def create_default_server(self) -> LSPServer:
+        return LocalServer(command=["typescript-language-server", "--stdio"])
+
     @override
     def create_initialization_options(self) -> dict[str, Any]:
         return {