File tree Expand file tree Collapse file tree 1 file changed +0
-6
lines changed
Expand file tree Collapse file tree 1 file changed +0
-6
lines changed Original file line number Diff line number Diff line change @@ -32,18 +32,12 @@ async def test_client_capabilities_match_container(client_cls):
3232
3333 mismatches = []
3434 async for result in inspect_capabilities (server , client_cls ):
35- # We only care about capabilities that the client CLAIMS to support but the server doesn't,
36- # or vice versa (though usually we care more about the client expecting something the server doesn't provide)
3735 if result .client != result .server :
3836 mismatches .append (
3937 f"{ result .capability } : client={ result .client } , server={ result .server } "
4038 )
4139
4240 if mismatches :
43- # For now, let's just log them or fail if we want strict matching.
44- # The user asked to "detect", so failing on mismatch is a good way to ensure they stay in sync.
45- # However, some servers might legitimately not support some things that we've implemented in the client (maybe for newer versions).
46- # But usually they should match if we are targeting a specific version in the container.
4741 pytest .fail (
4842 f"Capability mismatch for { client_cls .__name__ } :\n " + "\n " .join (mismatches )
4943 )
You can’t perform that action at this time.
0 commit comments