feat: add Deno LSP client #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@copilot review |
Contributor
|
@observerw I've opened a new pull request, #6, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive support for the Deno Language Server Protocol (LSP) client, including Deno-specific custom capabilities and experimental features. The implementation introduces protocol extensions for experimental capabilities and provides a full-featured Deno client with support for TypeScript/JavaScript development.
- Adds
ExperimentalCapabilityProtocolto support LSP experimental capabilities - Implements Deno LSP client with custom requests/notifications and testing API
- Includes comprehensive models for Deno-specific protocol extensions
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lsp_client/protocol/capability.py | Adds ExperimentalCapabilityProtocol for LSP experimental capabilities support |
| src/lsp_client/protocol/init.py | Exports the new ExperimentalCapabilityProtocol |
| src/lsp_client/capability/build.py | Updates capability builder to register experimental capabilities |
| src/lsp_client/clients/deno/models.py | Defines comprehensive Deno LSP models including requests, responses, and notifications |
| src/lsp_client/clients/deno/extension.py | Implements Deno-specific protocol extensions with request/notification handlers |
| src/lsp_client/clients/deno/client.py | Core Deno LSP client implementation with initialization and installation logic |
| src/lsp_client/clients/deno/init.py | Exports Deno client and server classes |
| src/lsp_client/clients/deno/README.md | Documents Deno LSP custom capabilities and usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
- Simplify ensure_installed method to use only the official shell script - Remove fallback installation methods for cleaner implementation - Use curl -fsSL https://deno.land/install.sh | sh for installation
- Add missing subprocess import - Ensure proper shell command execution for piped install script
- Replace DockerServer with ContainerServer for consistency - Add create_default_server method following standard pattern - Update __init__.py to export DenoContainerServer - Remove unused DenoLocalServer and DenoDockerServer partials - Follow the same import and structure patterns as other clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
src/lsp_client/clients/deno/.