Fixed several issues reported by PVS Studio static analyzer

Author: sadko4u

CHANGELOG

@@ -3,6 +3,7 @@
 *******************************************************************************
 
 === 1.0.15 ===
+* Fixed several issues reported by PVS Studio static analyzer.
 * Fixed syntax error in C interface, covered with tests.
 * Bugfix in horizontal summing functions (invalid register clobber list).
 * Some AMD-related optimizations.

README.md

@@ -32,8 +32,7 @@ Current set of functions provided:
   * Interpolation functions;
   * Some set of function to work with 3D mathematics.
 
-Supported platforms
-======
+## Supported platforms
 
 The build and correct unit test execution has been confirmed for following platforms:
 * FreeBSD
@@ -42,8 +41,7 @@ The build and correct unit test execution has been confirmed for following platf
 * Windows 32-bit
 * Windows 64-bit
 
-Supported architectures
-======
+## Supported architectures
 
 The support of following list of hardware architectures has been implemented:
 * i386 (32-bit) - full support.
@@ -55,16 +53,14 @@ The support of following list of hardware architectures has been implemented:
 For all other architectures the generic implementation of algorithms is used, without any
 architecture-specific optimizations. 
 
-Requirements
-======
+## Requirements
 
 The following packages need to be installed for building:
 
 * gcc >= 4.9
 * make >= 4.0
 
-Building
-======
+## Building
 
 To build the library, perform the following commands:
 
@@ -203,4 +199,6 @@ int main(int argc, const char **argv)
 
 ```
 
+## SAST Tools
 
+* [PVS-Studio](https://pvs-studio.com/en/pvs-studio/?utm_source=website&utm_medium=github&utm_campaign=open_source) - static analyzer for C, C++, C#, and Java code.

include/private/dsp/arch/generic/context.h

@@ -1,6 +1,6 @@
 /*
- * Copyright (C) 2020 Linux Studio Plugins Project <https://lsp-plug.in/>
- *           (C) 2020 Vladimir Sadovnikov <[email protected]>
+ * Copyright (C) 2023 Linux Studio Plugins Project <https://lsp-plug.in/>
+ *           (C) 2023 Vladimir Sadovnikov <[email protected]>
  *
  * This file is part of lsp-dsp-lib
  * Created on: 31 мар. 2020 г.
@@ -44,28 +44,32 @@ namespace lsp
 
         dsp::info_t *info()
         {
-            size_t size     =
-                    sizeof(dsp::info_t) +
+            size_t szof_dsp_info    = sizeof(dsp::info_t);
+            size_t size             =
+                    szof_dsp_info +
                     strlen(ARCH_STRING) + 1 +
                     strlen("native cpu") + 1 +
                     strlen("unknown") + 1;
 
-            dsp::info_t *res = reinterpret_cast<dsp::info_t *>(malloc(size));
-            if (res == NULL)
-                return res;
+            uint8_t *ptr        = static_cast<uint8_t *>(malloc(size));
+            if (ptr == NULL)
+                return NULL;
 
-            char *text  = reinterpret_cast<char *>(&res[1]);
-            res->arch       = text;
-            text            = stpcpy(text, ARCH_STRING) + 1;
-            res->cpu        = text;
-            text            = stpcpy(text, "native cpu") + 1;
-            res->model      = text;
-            text            = stpcpy(text, "unknown");
-            res->features   = text; // Empty string
+            dsp::info_t *res    = reinterpret_cast<dsp::info_t *>(ptr);
+            ptr                += szof_dsp_info;
+
+            char *text          = reinterpret_cast<char *>(ptr);
+            res->arch           = text;
+            text                = stpcpy(text, ARCH_STRING) + 1;
+            res->cpu            = text;
+            text                = stpcpy(text, "native cpu") + 1;
+            res->model          = text;
+            text                = stpcpy(text, "unknown");
+            res->features       = text; // Empty string
 
             return res;
         }
-    }
-}
+    } /* namespace generic */
+} /* namespace lsp */
 
 #endif /* PRIVATE_DSP_ARCH_GENERIC_CONTEXT_H_ */

src/main/x86/x86.cpp

@@ -1,6 +1,6 @@
 /*
- * Copyright (C) 2020 Linux Studio Plugins Project <https://lsp-plug.in/>
- *           (C) 2020 Vladimir Sadovnikov <[email protected]>
+ * Copyright (C) 2023 Linux Studio Plugins Project <https://lsp-plug.in/>
+ *           (C) 2023 Vladimir Sadovnikov <[email protected]>
  *
  * This file is part of lsp-dsp-lib
  * Created on: 31 мар. 2020 г.
@@ -521,23 +521,12 @@
                                 return true;
                         }
                         break;
+
                     case FEAT_FAST_AVX:
-                        if (f->vendor == CPU_VENDOR_INTEL) // Any Intel CPU is good enough with AVX
-                            return true;
-                        // Only starting with ZEN 1 architecture AMD's implementation of AVX is fast enough
-                        if ((f->vendor == CPU_VENDOR_AMD) || (f->vendor == CPU_VENDOR_HYGON))
-                        {
-                            if (f->family < AMD_FAMILY_ZEN_1_2)
-                                return false;
-                            if (f->family == AMD_FAMILY_DHYANA)
-                                return false;
-                            return true;
-                        }
-                        break;
                     case FEAT_FAST_FMA3:
                         if (f->vendor == CPU_VENDOR_INTEL) // Any Intel CPU is good enough with AVX
                             return true;
-                        // Starting with ZEN 2 FMA3 operations are fast enough on AMD
+                        // Only starting with ZEN 1 architecture AMD's implementation of AVX is fast enough
                         if ((f->vendor == CPU_VENDOR_AMD) || (f->vendor == CPU_VENDOR_HYGON))
                         {
                             if (f->family < AMD_FAMILY_ZEN_1_2)