enable beaker multihost acceptance testing

Author: jhoblitt

.github/workflows/ci.yml

@@ -4,15 +4,24 @@
 
 name: CI
 
-"on": pull_request
+# yamllint disable-line rule:truthy
+on:
+  pull_request: {}
+  push:
+    branches:
+      - main
+      - master
 
 concurrency:
   group: ${{ github.ref_name }}
   cancel-in-progress: true
 
+permissions:
+  contents: read
+
 jobs:
   puppet:
     name: Puppet
-    uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v2
+    uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v4
     with:
-      pidfile_workaround: 'false'
+      beaker_hosts: master;replica;client

.sync.yml

@@ -20,3 +20,7 @@ spec/spec_helper_acceptance.rb:
   delete: true
 .github/workflows/markdownlint.yaml:
   delete: true
+
+.github/workflows/ci.yml:
+  with:
+    beaker_hosts: master,replica,client

Gemfile

@@ -7,7 +7,7 @@ group :test do
   gem 'voxpupuli-test', '~> 7.0',   :require => false
   gem 'coveralls',                  :require => false
   gem 'simplecov-console',          :require => false
-  gem 'puppet_metadata', '~> 3.5',  :require => false
+  gem 'puppet_metadata', '~> 5.0',  :require => false
 end
 
 group :development do

examples/client.pp

@@ -6,6 +6,6 @@
   domain                => 'example.com',
   domain_join_principal => 'admin',
   domain_join_password  => 'rspecrspec123',
-  ipa_master_fqdn       => 'master.example.com',
+  ipa_master_fqdn       => 'master-puppet8.example.com',
   configure_ntp         => false,  # chronyd usually fails under gha
 }

examples/replica.pp

@@ -5,7 +5,7 @@
 -> class { 'ipa':
   ipa_role             => 'replica',
   domain               => 'example.com',
-  ipa_master_fqdn      => 'master.example.com',
+  ipa_master_fqdn      => 'master-puppet8.example.com',
   admin_password       => 'rspecrspec123',
   configure_dns_server => false,
   configure_ntp        => false,

spec/acceptance/master_spec.rb

@@ -4,13 +4,16 @@
 
 # server/replica is only supported on Redhat
 if fact_on('master', 'os.family') == 'RedHat'
-  describe 'easy_ipa class' do
+  describe 'ipa master' do
     include_examples 'the example', 'master.pp', 'master'
   end
-end
 
-if fact_on('client', 'os.family') == 'RedHat'
-  describe 'easy_ipa class' do
+  # replica setup timesout under gha
+  # describe 'ipa replica' do
+  #   include_examples 'the example', 'replica.pp', 'replica'
+  # end
+
+  describe 'ipa client' do
     include_examples 'the example', 'client.pp', 'client'
   end
 end

spec/support/acceptance/setup.rb

@@ -2,10 +2,6 @@
 
 configure_beaker(modules: :metadata) do |host|
   on(host, 'sysctl -w net.ipv6.conf.lo.disable_ipv6=0')
-  # disable sticky bit owner enforcement for ipa 4.6/EL7
-  # https://bugzilla.redhat.com/show_bug.cgi?id=1677027
-  # https://pagure.io/freeipa/c/87496d647706462fa8a10bbea5637104153146b2
-  on(host, 'sysctl -w fs.protected_regular=0')
   install_puppet_module_via_pmt_on(host, 'puppet/cron')
   install_puppet_module_via_pmt_on(host, 'puppet/epel')
 end