Skip to content

Commit 610c80c

Browse files
committed
Add tests, and check for deprecation warning
1 parent cf8dc3f commit 610c80c

File tree

2 files changed

+22
-3
lines changed

2 files changed

+22
-3
lines changed

python/lsst/summit/utils/utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@
8686
"obsInfoToDict",
8787
"getFieldNameAndTileNumber",
8888
"getAirmassSeeingCorrection",
89-
"getFilterSeeingCorrection",
89+
"getFilterSeeingCorrection", # deprecated
90+
"getBandpassSeeingCorrection",
9091
"getCdf",
9192
"getQuantiles",
9293
"digitizeData",

tests/test_utils.py

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,18 +42,19 @@
4242
from lsst.obs.base.makeRawVisitInfoViaObsInfo import MakeRawVisitInfoViaObsInfo
4343
from lsst.obs.lsst import Latiss
4444
from lsst.obs.lsst.translators.latiss import AUXTEL_LOCATION
45+
from lsst.summit.utils.utils import getFilterSeeingCorrection # deprecated
4546
from lsst.summit.utils.utils import (
4647
calcEclipticCoords,
4748
computeCcdExposureId,
4849
computeExposureId,
4950
fluxesFromFootprints,
5051
getAirmassSeeingCorrection,
52+
getBandpassSeeingCorrection,
5153
getCurrentDayObs_datetime,
5254
getCurrentDayObs_humanStr,
5355
getCurrentDayObs_int,
5456
getExpPositionOffset,
5557
getFieldNameAndTileNumber,
56-
getFilterSeeingCorrection,
5758
getQuantiles,
5859
quickSmooth,
5960
)
@@ -189,7 +190,24 @@ def test_getAirmassSeeingCorrection(self):
189190

190191
def test_getFilterSeeingCorrection(self):
191192
for filterName in ("SDSSg_65mm", "SDSSr_65mm", "SDSSi_65mm"):
192-
correction = getFilterSeeingCorrection(filterName)
193+
with self.assertWarns(FutureWarning):
194+
correction = getFilterSeeingCorrection(filterName)
195+
self.assertGreater(correction, 0.5)
196+
self.assertLess(correction, 1.5)
197+
198+
def test_getBandpassSeeingCorrection(self):
199+
for filterName in (
200+
"SDSSg_65mm",
201+
"SDSSr_65mm",
202+
"SDSSi_65mm",
203+
"u_02",
204+
"g_01",
205+
"r_03",
206+
"i_06",
207+
"z_03",
208+
"y_04",
209+
):
210+
correction = getBandpassSeeingCorrection(filterName)
193211
self.assertGreater(correction, 0.5)
194212
self.assertLess(correction, 1.5)
195213

0 commit comments

Comments
 (0)