Fix all ESLint unused variable warnings - clean codebase

Co-authored-by: lstein <111189+lstein@users.noreply.github.com>

Author: Copilot

photomap/frontend/static/javascript/about.js

@@ -143,13 +143,13 @@ class AboutManager {
                       setTimeout(() => window.location.reload(), 1000);
                       return;
                     }
-                  } catch (e) {
+                  } catch {
                     // Ignore errors, server is still down
                   }
                   setTimeout(pollForServer, 2000);
                 })();
               }, 5000);
-            } catch (e) {
+            } catch {
               updateStatus.textContent = "Update complete. Please refresh manually.";
             }
           }, 1000);

photomap/frontend/static/javascript/album-manager.js

@@ -270,7 +270,7 @@ export class AlbumManager {
     }
   }
 
-  _createAlbumPathRow({ path = "", onAddRow, onRemoveRow, onFolderPick, container } = {}) {
+  _createAlbumPathRow({ path = "", onAddRow, onRemoveRow, onFolderPick } = {}) {
     const wrapper = document.createElement("div");
     wrapper.className = "album-path-row";
     wrapper.style.cssText = `
@@ -636,7 +636,7 @@ export class AlbumManager {
         status.style.color = "red";
         createBtn.textContent = "Create Index";
       }
-    } catch (e) {
+    } catch {
       status.textContent = "No index present";
       status.style.color = "red";
       createBtn.textContent = "Create Index";
@@ -988,7 +988,7 @@ export class AlbumManager {
           return;
         }
       }
-    } catch (error) {
+    } catch {
       console.debug(`Could not check backend indexing status for album: ${albumKey}`);
     }
 
@@ -1035,7 +1035,6 @@ export class AlbumManager {
     const progressContainer = cardElement.querySelector(".progress-container");
     const cancelBtn = cardElement.querySelector(".cancel-index-btn");
     const status = cardElement.querySelector(".index-status");
-    const estimatedTime = cardElement.querySelector(".estimated-time");
 
     progressContainer.style.display = "block";
     createBtn.style.display = "none";
@@ -1287,7 +1286,7 @@ export class AlbumManager {
             return { albumKey, restored: true };
           }
         }
-      } catch (error) {
+      } catch {
         console.debug(`No ongoing operation for album: ${albumKey}`);
       }
 

photomap/frontend/static/javascript/bookmarks.js

@@ -85,7 +85,7 @@ class BookmarkManager {
 
   setupEventListeners() {
     // Listen for album changes to load bookmarks for the new album
-    window.addEventListener("albumChanged", (e) => {
+    window.addEventListener("albumChanged", () => {
       this.loadBookmarks();
       this.isShowingBookmarks = false;
       this.previousSearchResults = null;
@@ -372,7 +372,7 @@ class BookmarkManager {
     }
 
     // Create search results from bookmarked indices
-    const results = indices.map((index, i) => ({
+    const results = indices.map((index) => ({
       index: index,
       score: 1.0,
       cluster: null,

photomap/frontend/static/javascript/control-panel.js

@@ -92,7 +92,7 @@ function handleCopyText() {
 
 // Delete the current file
 async function handleDeleteCurrentFile() {
-  const [globalIndex, totalImages, searchIndex] = getCurrentSlideIndex();
+  const [globalIndex, , searchIndex] = getCurrentSlideIndex();
   const currentFilepath = await getCurrentFilepath();
 
   if (globalIndex === -1 || !currentFilepath) {
@@ -129,7 +129,7 @@ function showDeleteConfirmModal(filepath, globalIndex) {
     dontAsk.checked = false;
     modal.style.display = "flex";
 
-    function cleanup(result) {
+    function cleanup() {
       modal.style.display = "none";
       cancelBtn.removeEventListener("click", onCancel);
       confirmBtn.removeEventListener("click", onConfirm);

photomap/frontend/static/javascript/curation.js

@@ -8,7 +8,6 @@ import { hideSpinner, showSpinner } from "./utils.js";
 
 let currentSelectionIndices = new Set();
 const excludedIndices = new Set();
-let currentSelectionFiles = [];
 let analysisResults = [];
 let isExcludeMode = false;
 
@@ -214,9 +213,6 @@ function setupEventListeners() {
   const lockThresholdBtn = document.getElementById("lockThresholdBtn");
   const unlockBtn = document.getElementById("unlockOutliersBtn");
 
-  const methodFps = document.getElementById("methodFps");
-  const methodKmeans = document.getElementById("methodKmeans");
-
   if (!runBtn) {
     return;
   }
@@ -469,7 +465,6 @@ function setupEventListeners() {
                 currentSelectionIndices.add(idx);
               }
             });
-            currentSelectionFiles = data.selected_files;
             analysisResults = data.analysis_results;
 
             // Merge new results into Global Metadata Map
@@ -665,7 +660,6 @@ function clearSelectionData() {
   highFreqIndices.clear();
   medFreqIndices.clear();
   lowFreqIndices.clear();
-  currentSelectionFiles = [];
   // Do NOT clear globalMetadataMap here, as we want to remember excluded items from previous runs
 }
 

photomap/frontend/static/javascript/events.js

@@ -182,8 +182,7 @@ export function showHidePanelText(hide) {
 }
 
 // Listen for slide changes to update UI
-window.addEventListener("slideChanged", (e) => {
-  const { globalIndex, searchIndex, totalCount, isSearchMode } = e.detail;
+window.addEventListener("slideChanged", () => {
   // nothing to do here yet, but could be used to update UI elements
 });
 

photomap/frontend/static/javascript/filetree.js

@@ -137,7 +137,7 @@ export class DirectoryPicker {
               try {
                 const error = await response.json();
                 errorMessage = error.detail || errorMessage;
-              } catch (e) {
+              } catch {
                 // JSON parsing failed, use default message
               }
             }

photomap/frontend/static/javascript/grid-view.js

@@ -150,15 +150,15 @@ class GridViewManager {
   }
 
   addGridEventListeners() {
-    this.addEventListener(window, "swiperModeChanged", async (e) => {
+    this.addEventListener(window, "swiperModeChanged", async () => {
       await this.resetAllSlides();
     });
 
-    this.addEventListener(window, "searchResultsChanged", async (e) => {
+    this.addEventListener(window, "searchResultsChanged", async () => {
       await this.resetAllSlides();
     });
 
-    this.addEventListener(window, "slideChanged", async (e) => {
+    this.addEventListener(window, "slideChanged", async () => {
       // nothing for now
     });
 
@@ -170,7 +170,7 @@ class GridViewManager {
     });
 
     this.addEventListener(window, "seekToSlideIndex", async (e) => {
-      const { globalIndex, searchIndex, totalSlides, isSearchMode } = e.detail;
+      const { globalIndex, isSearchMode } = e.detail;
       if (isSearchMode !== slideState.isSearchMode) {
         console.error("Mismatched search mode in setSlideIndex event");
         return;
@@ -299,7 +299,7 @@ class GridViewManager {
       return;
     }
     let lastTap = 0;
-    slideEl.addEventListener("touchend", (e) => {
+    slideEl.addEventListener("touchend", () => {
       const now = Date.now();
       if (now - lastTap < 350) {
         window.handleGridSlideDblClick(globalIndex);

photomap/frontend/static/javascript/metadata-drawer.js

@@ -224,7 +224,7 @@ metadataLink.addEventListener("click", async (e) => {
     } else {
       metadataTextArea.value = "Failed to load metadata.";
     }
-  } catch (err) {
+  } catch {
     metadataTextArea.value = "Error loading metadata.";
   }
 });

photomap/frontend/static/javascript/search-ui.js

@@ -176,7 +176,7 @@ document.addEventListener("DOMContentLoaded", async () => {
     }
   });
 
-  textSearchPanel.addEventListener("transitionend", (e) => {
+  textSearchPanel.addEventListener("transitionend", () => {
     if (textSearchPanel.style.opacity === "0") {
       textSearchPanel.style.display = "none";
       const noResultsMsg = document.getElementById("noResultsMsg");
@@ -353,7 +353,7 @@ document.addEventListener("DOMContentLoaded", async () => {
   renderSearchImageThumbArea();
 });
 
-export async function searchWithImage(file, first_slide) {
+export async function searchWithImage(file) {
   try {
     showSpinner();
     let results = await searchImage(file);