remove pwd_show_policy_onerror unused variable (#78)

Author: David Coutadeur

src/Ltb/Ppolicy.php

@@ -254,14 +254,6 @@ static function smarty_assign_ppolicy($smarty, $pwd_show_policy_pos, $pwd_show_p
         if (isset($pwd_show_policy_pos)) {
             $smarty->assign('pwd_show_policy_pos', $pwd_show_policy_pos);
             $smarty->assign('pwd_show_policy', $pwd_show_policy);
-            $smarty->assign('pwd_show_policy_onerror', true);
-            if ( $pwd_show_policy === "onerror" ) {
-                if ( !preg_match( "/tooshort|toobig|minlower|minupper|mindigit|minspecial|forbiddenchars|sameasold|notcomplex|sameaslogin|pwned|specialatends/" , $result) ) {
-                    $smarty->assign('pwd_show_policy_onerror', false);
-                } else {
-                    $smarty->assign('pwd_show_policy_onerror', true);
-                }
-            }
             self::smarty_assign_variable($smarty, $pwd_policy_config);
 
             // send policy to a JSON object usable in javascript

tests/Ltb/PpolicyTest.php

@@ -340,9 +340,6 @@ public function test_smarty_assign_ppolicy()
         $smarty->shouldreceive('assign')
                ->once()
                ->with("pwd_show_policy", $pwd_show_policy );
-        $smarty->shouldreceive('assign')
-               ->once()
-               ->with("pwd_show_policy_onerror", true );
 
         foreach ($pwd_policy_config as $param => $value) {
             if( isset($value) )
@@ -368,65 +365,4 @@ public function test_smarty_assign_ppolicy()
 
     }
 
-    public function test_smarty_assign_ppolicy_show_policy_onerror()
-    {
-
-        $pwd_policy_config = array();
-
-        $smarty = Mockery::mock('Smarty');
-        $pwd_show_policy_pos = "above";
-        $pwd_show_policy = "onerror";
-        $result = "forbiddenchars";
-
-        $smarty->shouldreceive('assign')
-               ->once()
-               ->with("pwd_show_policy_pos", $pwd_show_policy_pos );
-        $smarty->shouldreceive('assign')
-               ->once()
-               ->with("pwd_show_policy", $pwd_show_policy );
-        $smarty->shouldreceive('assign')
-               ->twice()
-               ->with("pwd_show_policy_onerror", true );
-
-        $smarty->shouldreceive('assign')
-               ->once()
-               ->with("json_policy", base64_encode(json_encode( $pwd_policy_config )) );
-
-        \Ltb\Ppolicy::smarty_assign_ppolicy($smarty, $pwd_show_policy_pos, $pwd_show_policy, $result, $pwd_policy_config);
-
-        $this->assertNotNull($smarty, "smarty variable is null while testing smarty_assign_ppolicy" );
-
-    }
-
-    public function test_smarty_assign_ppolicy_show_policy_onerror_dummy()
-    {
-
-        $pwd_policy_config = array();
-
-        $smarty = Mockery::mock('Smarty');
-        $pwd_show_policy_pos = "above";
-        $pwd_show_policy = "onerror";
-        $result = "dummy";
-
-        $smarty->shouldreceive('assign')
-               ->once()
-               ->with("pwd_show_policy_pos", $pwd_show_policy_pos );
-        $smarty->shouldreceive('assign')
-               ->once()
-               ->with("pwd_show_policy", $pwd_show_policy );
-        $smarty->shouldreceive('assign')
-               ->with("pwd_show_policy_onerror", true );
-        $smarty->shouldreceive('assign')
-               ->with("pwd_show_policy_onerror", false );
-
-        $smarty->shouldreceive('assign')
-               ->once()
-               ->with("json_policy", base64_encode(json_encode( $pwd_policy_config )) );
-
-        \Ltb\Ppolicy::smarty_assign_ppolicy($smarty, $pwd_show_policy_pos, $pwd_show_policy, $result, $pwd_policy_config);
-
-        $this->assertNotNull($smarty, "smarty variable is null while testing smarty_assign_ppolicy" );
-
-    }
-
 }