fix #99

Author: gam6itko

src/XBase/DataConverter/Field/DBase/NumberConverter.php

@@ -34,10 +34,11 @@ public function toBinaryString($value): string
             return str_repeat(chr(0x00), $this->column->getLength());
         }
 
-        if ($value % 1 > 0) {
-            $value = number_format($value, $this->column->getDecimalCount(), '.', '');
-        }
-
-        return str_pad((string) $value, $this->column->getLength(), ' ', STR_PAD_LEFT);
+        return str_pad(
+            number_format($value, $this->column->getDecimalCount(), '.', ''),
+            $this->column->getLength(),
+            ' ',
+            STR_PAD_LEFT
+        );
     }
 }

tests/DataConverter/Field/DBase/NumberConverterTest.php

@@ -0,0 +1,47 @@
+<?php declare(strict_types=1);
+
+namespace XBase\Tests\DataConverter\Field\DBase;
+
+use PHPUnit\Framework\TestCase;
+use XBase\Column\ColumnInterface;
+use XBase\DataConverter\Field\DBase\NumberConverter;
+use XBase\Table;
+
+/**
+ * @author Alexander Strizhak <[email protected]>
+ *
+ * @coversDefaultClass \XBase\DataConverter\Field\DBase\NumberConverter
+ */
+class NumberConverterTest extends TestCase
+{
+    /**
+     * Issue #99
+     * @covers ::toBinaryString
+     * @dataProvider dataRightDecimalCount
+     *
+     * @param int|float $in
+     */
+    public function testRightDecimalCount(int $length, int $decimalCount, $in, string $out)
+    {
+        $table = $this->createMock(Table::class);
+        $column = $this->createMock(ColumnInterface::class);
+        $column
+            ->method('getLength')
+            ->willReturn($length);
+        $column
+            ->method('getDecimalCount')
+            ->willReturn($decimalCount);
+
+        $fieldConverter = new NumberConverter($table, $column);
+        self::assertSame($out, $fieldConverter->toBinaryString($in));
+    }
+
+    public function dataRightDecimalCount()
+    {
+        yield [10, 3, null, str_repeat(chr(0x00), 10)];
+        yield [10, 0, 10, '        10'];
+        yield [10, 3, 10.123, '    10.123'];
+        yield [10, 3, 10, '    10.000'];
+        yield [10, 3, 1, '     1.000'];
+    }
+}