Trees spawn on village paths or inside houses with v7 map generator and mineclonia

[kostrahb]

Trees sometimes spawn on village paths and near or inside houses with tree leaves obstructing house interior with v7 map generator and mineclonia.

According to developers of Mineclonia this is more like a bug/feature of v7 generator:

This is a product of Luanti's not updating mapgen-provided heightmap information before decorations are manually generated by core.generate_decorations.

(Please refer to https://codeberg.org/mineclonia/mineclonia/issues/4210)

Luanti version: 5.15.1
Mineclonia version: 0.120.1
map seed: 4415923749439425173

[sfan5]

Please tell the Mineclonia devs to provide full reproduction steps (ideally with minimal code).

[nininik0]

This seems more of a mineclonia bug but uh ok - can confirm on kubuntu

[kostrahb]

After the discussion with mineclonia devs the root cause seems to be this:

heightmap information is not updated after villages are placed (this being performed prior to decoration placement) so that Luanti attempts to place trees on grass nodes whose top has already been obstructed by village buildings

Not sure about the minimal code snippet to reproduce the problem unfortunately.

Is there any way how to update heighmap after each step during map generation?

[sfan5]

02:08 <repetitivestrain> sfan5: regarding https://github.com/luanti-org/luanti/issues/16979: the issue is that core.generate_decorations reuses the heightmap provided by the map generator, while mineclonia edits the map before core.generate_decorations is called, in consequence of which decorations may generate above nodes at elevations in the heightmap whose tops have been obscured by such edits
11:57 <sfan5> repetitivestrain: sounds like "missing ability to edit the heightmap to adjust for user changes" instead, which is not a bug but a feature request