Override /pulverize and /clearinv to require interact
#3217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
changed the title
interact
SmallJoker
reviewed
Nov 13, 2025
| for _, cmd in ipairs({"pulverize", "clearinv"}) do | ||
| local def = core.registered_chatcommands[cmd] | ||
| if def then | ||
| if match_old(def.privs) then |
Member
There was a problem hiding this comment.
This depends on the mod load order. I think it would be more straight-forward to
EITHER:
Use a simple, general logic as possible:
if def.privs.give then
def.privs.give = nil
def.privs.interact = true
endOR:
Execute this in a on_mods_loaded callback.
Contributor
Author
There was a problem hiding this comment.
Is that a problem? If another mod wants to be sure to override it, it should depend on default
Member
There was a problem hiding this comment.
🤷. It depends on how the mod manipulates the table, whether an additional priv is added (assuming interact would be there too), or it's overwritten entirely. The code also seemed to me more complicated than it should be.
Anyway. I don't think this really matters, thus 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3214