Skip [tool] crash reporting on --local-engine (flutter#172326)

Closes flutter#70238.

Author: matanlurey

packages/flutter_tools/lib/runner.dart

@@ -46,6 +46,8 @@ Future<int> run(
     args.removeWhere((String option) => option == '-vv' || option == '-v' || option == '--verbose');
   }
 
+  final bool usingLocalEngine = args.any((a) => a.startsWith('--local-engine'));
+
   return runInContext<int>(() async {
     globals.terminal.applyFeatureFlags(featureFlags);
 
@@ -121,6 +123,7 @@ Future<int> run(
             getVersion,
             shutdownHooks,
             featureFlags: featureFlags,
+            usingLocalEngine: usingLocalEngine,
           );
         }
       },
@@ -139,6 +142,7 @@ Future<int> run(
           getVersion,
           shutdownHooks,
           featureFlags: featureFlags,
+          usingLocalEngine: usingLocalEngine,
         );
       },
     )!;
@@ -153,6 +157,7 @@ Future<int> _handleToolError(
   bool reportCrashes,
   String Function() getFlutterVersion,
   ShutdownHooks shutdownHooks, {
+  required bool usingLocalEngine,
   required FeatureFlags featureFlags,
 }) async {
   if (error is UsageException) {
@@ -205,25 +210,28 @@ Future<int> _handleToolError(
     }
 
     globals.analytics.send(Event.exception(exception: error.runtimeType.toString()));
-    await asyncGuard(
-      () async {
-        final crashReportSender = CrashReportSender(
-          platform: globals.platform,
-          logger: globals.logger,
-          operatingSystemUtils: globals.os,
-          analytics: globals.analytics,
-        );
-        await crashReportSender.sendReport(
-          error: error,
-          stackTrace: stackTrace!,
-          getFlutterVersion: getFlutterVersion,
-          command: args.join(' '),
-        );
-      },
-      onError: (dynamic error) {
-        globals.printError('Error sending crash report: $error');
-      },
-    );
+
+    if (!usingLocalEngine) {
+      await asyncGuard(
+        () async {
+          final crashReportSender = CrashReportSender(
+            platform: globals.platform,
+            logger: globals.logger,
+            operatingSystemUtils: globals.os,
+            analytics: globals.analytics,
+          );
+          await crashReportSender.sendReport(
+            error: error,
+            stackTrace: stackTrace!,
+            getFlutterVersion: getFlutterVersion,
+            command: args.join(' '),
+          );
+        },
+        onError: (dynamic error) {
+          globals.printError('Error sending crash report: $error');
+        },
+      );
+    }
 
     globals.printError('Oops; flutter has exited unexpectedly: "$error".');
 

packages/flutter_tools/test/general.shard/runner/runner_test.dart

@@ -120,6 +120,64 @@ void main() {
       },
     );
 
+    testUsingContext(
+      'error handling crash report (local engine)',
+      () async {
+        fileSystem
+            .directory('engine')
+            .childDirectory('src')
+            .childDirectory('out')
+            .createSync(recursive: true);
+
+        final completer = Completer<void>();
+        unawaited(
+          runZonedGuarded<Future<void>?>(
+            () {
+              unawaited(
+                runner.run(
+                  <String>[
+                    '--local-engine=host_debug',
+                    '--local-engine-src-path=./engine/src',
+                    'crash',
+                  ],
+                  () => <FlutterCommand>[CrashingFlutterCommand()],
+                  // This flutterVersion disables crash reporting.
+                  flutterVersion: '[user-branch]/',
+                  reportCrashes: true,
+                  shutdownHooks: ShutdownHooks(),
+                ),
+              );
+              return null;
+            },
+            (Object error, StackTrace stack) {
+              expect(firstExitCode, isNotNull);
+              expect(firstExitCode, isNot(0));
+              expect(error.toString(), 'Exception: test exit');
+              completer.complete();
+            },
+          ),
+        );
+        await completer.future;
+
+        expect(
+          fakeAnalytics.sentEvents,
+          isNot(contains(Event.exception(exception: '_Exception'))),
+          reason: 'Does not send a report when using --local-engine',
+        );
+      },
+      overrides: <Type, Generator>{
+        Platform: () => FakePlatform(
+          environment: <String, String>{'FLUTTER_ANALYTICS_LOG_FILE': 'test', 'FLUTTER_ROOT': '/'},
+        ),
+        FileSystem: () => fileSystem,
+        ProcessManager: () => FakeProcessManager.any(),
+        Artifacts: () => Artifacts.test(),
+        HttpClientFactory: () =>
+            () => FakeHttpClient.any(),
+        Analytics: () => fakeAnalytics,
+      },
+    );
+
     testUsingContext(
       'error handling crash report (bot)',
       () async {