Improving the filters test coverage

Author: Luca Degasperi

src/LucaDegasperi/OAuth2Server/Filters/CheckAuthorizationParamsFilter.php

@@ -0,0 +1,40 @@
+<?php namespace LucaDegasperi\OAuth2Server\Filters;
+
+use AuthorizationServer;
+use Response;
+use Session;
+
+class CheckAuthorizationParamsFilter {
+
+    public function filter($route, $request, $scope = null)
+    {
+        try {
+
+            $params = AuthorizationServer::getGrantType('authorization_code')->checkAuthoriseParams();
+
+            Session::put('client_id', $params['client_id']);
+            Session::put('client_details', $params['client_details']);
+            Session::put('redirect_uri', $params['redirect_uri']);
+            Session::put('response_type', $params['response_type']);
+            Session::put('scopes', $params['scopes']);
+            Session::put('state', $params['state']);
+
+
+        } catch (\League\OAuth2\Server\Exception\ClientException $e) {
+
+            return Response::json(array(
+                'status' => 400,
+                'error' => 'bad_request',
+                'error_message' => $e->getMessage(),
+            ), 400);
+
+        } catch (\Exception $e) {
+
+            return Response::json(array(
+                'status' => 500,
+                'error' => 'internal_server_error',
+                'error_message' => 'Internal Server Error',
+            ), 500);
+        }
+    }
+}

src/filters.php

@@ -1,37 +1,7 @@
 <?php
 
-Route::filter('check-authorization-params', function($route, $request, $scope = null)
-{
-    try {
-
-        $params = AuthorizationServer::getGrantType('authorization_code')->checkAuthoriseParams();
-
-        Session::put('client_id', $params['client_id']);
-        Session::put('client_details', $params['client_details']);
-        Session::put('redirect_uri', $params['redirect_uri']);
-        Session::put('response_type', $params['response_type']);
-        Session::put('scopes', $params['scopes']);
-        Session::put('state', $params['state']);
-
-
-    } catch (League\OAuth2\Server\Exception\ClientException $e) {
-
-        return Response::json(array(
-            'status' => 400,
-            'error' => 'bad_request',
-            'error_message' => $e->getMessage(),
-        ), 400);
-
-    } catch (Exception $e) {
-
-        return Response::json(array(
-            'status' => 500,
-            'error' => 'internal_server_error',
-            'error_message' => 'Internal Server Error',
-        ), 500);
-    }
-
-});
+// filter to check if the auth code grant type params are provided
+Route::filter('check-authorization-params', 'LucaDegasperi\OAuth2Server\Filters\CheckAuthorizationParamsFilter');
 
 // make sure an endpoint is accessible only by authrized members eventually with specific scopes 
 Route::filter('oauth', 'LucaDegasperi\OAuth2Server\Filters\OAuthFilter');

tests/AuthorizationServerFacadeTest.php

@@ -13,4 +13,8 @@ public function test_make_redirect()
         $this->assertEquals('example?', $redirect);
     }
 
+    public function tearDown() {
+        m::close();
+    }
+
 }

tests/CheckAuthorizationParamsFilterTest.php

@@ -0,0 +1,69 @@
+<?php
+
+use \Mockery as m;
+
+class CheckAuthorizationParamsFilterTest extends TestCase {
+
+    public function getFilter()
+    {
+        return new LucaDegasperi\OAuth2Server\Filters\CheckAuthorizationParamsFilter;
+    }
+
+    public function getStub()
+    {
+        return array(
+            'client_id' => 1,
+            'client_details' => 'foo',
+            'redirect_uri' => 'http://www.example.com/',
+            'response_type' => 'code',
+            'scopes' => 'scope',
+            'state' => '123456789',
+        );
+    }
+
+    public function test_with_valid_params()
+    {
+        $stub = $this->getStub();
+
+        AuthorizationServer::shouldReceive('getGrantType->checkAuthoriseParams')
+                           ->once()
+                           ->andReturn($stub);
+
+        Session::shouldReceive('put')->times(6);
+
+        $response = $this->getFilter()->filter('','', null);
+
+        $this->assertNull($response);
+    }
+
+    public function test_with_invalid_valid_params()
+    {
+
+        AuthorizationServer::shouldReceive('getGrantType->checkAuthoriseParams')
+                           ->once()
+                           ->andThrow(new \League\OAuth2\Server\Exception\ClientException('Invalid Request'));
+
+        $response = $this->getFilter()->filter('','', null);
+
+        $this->assertTrue($response instanceof Illuminate\Http\JsonResponse);
+        $this->assertTrue($response->isClientError());
+    }
+
+    public function test_with_server_error()
+    {
+
+        AuthorizationServer::shouldReceive('getGrantType->checkAuthoriseParams')
+                           ->once()
+                           ->andThrow(new Exception('Internal Server Error'));
+
+        $response = $this->getFilter()->filter('','', null);
+
+        $this->assertTrue($response instanceof Illuminate\Http\JsonResponse);
+        $this->assertTrue($response->isServerError());
+    }
+
+    public function tearDown() {
+        m::close();
+    }
+
+}

tests/OAuthOwnerFilterTest.php

@@ -26,4 +26,8 @@ public function test_with_unexisting_owner_type()
         $this->assertTrue($response->isForbidden());
     }
 
+    public function tearDown() {
+        m::close();
+    }
+
 }