Skip to content

Commit ad6ff96

Browse files
committed
Merge pull request #504 from lucadegasperi/contributing
Add new contributing guidelines
2 parents c3e4856 + 009e56f commit ad6ff96

File tree

1 file changed

+25
-8
lines changed

1 file changed

+25
-8
lines changed

CONTRIBUTING.md

Lines changed: 25 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,32 @@
1-
Thanks for contributing to this project.
1+
# CONTRIBUTING
22

3-
Everytime you open an issue please state which version of Laravel are you using and which version of this package are you using.
4-
This is very important so that problems can be issued quicker.
3+
Contributions are welcome, and are accepted via pull requests. Please review these guidelines before submitting any pull requests.
54

5+
## Guidelines
66

7-
Please ensure that you run `phpunit` from the project root after you've made any changes.
7+
* Please follow the [PSR-2 Coding Standard](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md) and [PHP-FIG Naming Conventions](https://github.com/php-fig/fig-standards/blob/master/bylaws/002-psr-naming-conventions.md).
8+
* Ensure that the current tests pass, and if you've added something new, add the tests where relevant.
9+
* Remember that we follow [SemVer](http://semver.org). If you are changing the behaviour, or the public api, you may need to update the docs.
10+
* Send a coherent commit history, making sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please [squash](http://git-scm.com/book/en/Git-Tools-Rewriting-History) them before submitting.
11+
* You may also need to [rebase](http://git-scm.com/book/en/Git-Branching-Rebasing) to avoid merge conflicts.
812

9-
If you've added something new please create a new unit test, if you've changed something please update any unit tests as appropritate.
1013

11-
We're trying to ensure there is **100%** test code coverage (including testing PHP errors and exceptions) so please ensure any new/updated tests cover all of your changes.
14+
## Running Tests
1215

13-
Thank you,
16+
You will need an install of [Composer](https://getcomposer.org) before continuing.
1417

15-
@lucadegasperi
18+
First, install the dependencies:
19+
20+
```bash
21+
$ composer install
22+
```
23+
24+
Then run phpunit:
25+
26+
```bash
27+
$ vendor/bin/phpunit
28+
```
29+
30+
If the test suite passes on your local machine you should be good to go.
31+
32+
When you make a pull request, the tests will automatically be run again by [Travis CI](https://travis-ci.org/) on multiple php versions and hhvm.

0 commit comments

Comments
 (0)