Merge pull request #30 from lucaromagnoli/feat/add-models

Feat/add models

Author: lucaromagnoli

.github/workflows/ci.yml

@@ -18,6 +18,7 @@ on:
 
 jobs:
   build-and-test:
+    if: github.event_name != 'push' || !startsWith(github.ref, 'refs/tags/')
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
@@ -115,6 +116,22 @@ jobs:
         echo "Running CI-safe tests (excluding integration tests)..."
         ./tests/llmcpp_tests "~[integration]" --reporter compact
 
+    # Code quality checks (only on PRs to main/develop)
+    - name: Check formatting (Linux only)
+      if: matrix.os == 'ubuntu-22.04' && github.event_name == 'pull_request'
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y clang-format
+        find include src tests -name "*.h" -o -name "*.hpp" -o -name "*.cpp" -o -name "*.c" | xargs clang-format --dry-run --style=file
+
+    - name: Run static analysis (Linux only)
+      if: matrix.os == 'ubuntu-22.04' && github.event_name == 'pull_request'
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y cppcheck
+        cppcheck --enable=warning --inline-suppr --suppress=missingIncludeSystem --suppress=useInitializationList --suppress=unusedParameter --error-exitcode=0 -I include/ src/ include/
+      continue-on-error: true
+
     - name: Upload build artifacts
       if: failure()
       uses: actions/upload-artifact@v4

.github/workflows/code-quality.yml

@@ -9,7 +9,63 @@ env:
   CMAKE_VERSION: '3.22'
 
 jobs:
+  check-open-prs:
+    runs-on: ubuntu-latest
+    outputs:
+      has_open_prs: ${{ steps.check.outputs.has_open_prs }}
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Check for open PRs
+        id: check
+        run: |
+          # Check if there are any open PRs targeting main or develop
+          OPEN_PRS=$(gh pr list --state open --base main --base develop --json number --jq 'length')
+          if [ "$OPEN_PRS" -gt 0 ]; then
+            echo "has_open_prs=true" >> $GITHUB_OUTPUT
+            echo "⚠️ Found $OPEN_PRS open PR(s). Skipping release to avoid duplicates."
+            echo "Release will run after PR is merged."
+          else
+            echo "has_open_prs=false" >> $GITHUB_OUTPUT
+            echo "✅ No open PRs found. Proceeding with release."
+          fi
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+  check-ci-status:
+    needs: check-open-prs
+    if: needs.check-open-prs.outputs.has_open_prs == 'false'
+    runs-on: ubuntu-latest
+    outputs:
+      ci_passed: ${{ steps.check.outputs.ci_passed }}
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Check if CI has already passed
+        id: check
+        run: |
+          # Get the commit SHA
+          COMMIT_SHA="${{ github.sha }}"
+          echo "Checking CI status for commit: $COMMIT_SHA"
+
+          # Check if there's a successful CI run for this commit
+          CI_STATUS=$(gh api repos/${{ github.repository }}/commits/$COMMIT_SHA/status --jq '.statuses[] | select(.context == "CI") | .state' 2>/dev/null || echo "unknown")
+
+          if [ "$CI_STATUS" = "success" ]; then
+            echo "ci_passed=true" >> $GITHUB_OUTPUT
+            echo "✅ CI has already passed for this commit. Skipping build-and-test."
+          else
+            echo "ci_passed=false" >> $GITHUB_OUTPUT
+            echo "⚠️ CI has not passed yet or status unknown. Running build-and-test."
+          fi
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
   validate-version:
+    needs: [check-open-prs, check-ci-status]
+    if: needs.check-open-prs.outputs.has_open_prs == 'false'
     runs-on: ubuntu-latest
     outputs:
       version: ${{ steps.extract.outputs.version }}
@@ -80,7 +136,8 @@ jobs:
           echo "✅ Changelog validation passed: version $VERSION found in CHANGELOG.md"
 
   build-and-test:
-    needs: validate-version
+    needs: [check-open-prs, check-ci-status, validate-version]
+    if: needs.check-open-prs.outputs.has_open_prs == 'false' && needs.check-ci-status.outputs.ci_passed == 'false'
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
@@ -184,7 +241,8 @@ jobs:
           retention-days: 30
 
   create-release:
-    needs: [validate-version, build-and-test]
+    needs: [check-open-prs, check-ci-status, validate-version, build-and-test]
+    if: needs.check-open-prs.outputs.has_open_prs == 'false'
     runs-on: ubuntu-latest
     permissions:
       contents: write

.github/workflows/release.yml

@@ -4,6 +4,39 @@
 
 
 
+## [1.0.17] - 2025-07-13
+
+### Fixed
+- add explicit condition to skip CI on tag pushes
+
+## [1.0.16] - 2025-07-13
+
+### Fixed
+- add checkout step to check-open-prs job in release workflow
+
+## [1.0.15] - 2025-07-13
+
+### Build
+- do not run CI workflow on version tags (only release workflow runs on tags)
+- optimize workflows - merge code quality into CI and skip release on open PRs
+
+## [1.0.14] - 2025-07-13
+
+### Fixed
+- correct GPT-4.5 model status - it's a current preview model, not deprecated
+- update tests to use correct GPT-4.5 model string (gpt-4.5-preview)
+- implement parameter filtering for reasoning models (O-series)
+
+### Documentation
+- update README to clarify model enum usage and remove recommendation references
+
+### Maintenance
+- remove duplicate release-workflow.sh script
+
+### Other
+- Merge pull request #29 from lucaromagnoli/feat/release-test
+- Remove getRecommendedModel and related tests, clean up OpenAI model enum logic
+
 ## [1.0.13] - 2025-07-13
 
 ### Changed

CHANGELOG.md

@@ -1,6 +1,6 @@
 cmake_minimum_required(VERSION 3.22)
 
-project(llmcpp VERSION 1.0.13 LANGUAGES CXX)
+project(llmcpp VERSION 1.0.17 LANGUAGES CXX)
 
 # Set version variables for easier access
 set(LLMCPP_VERSION_MAJOR ${PROJECT_VERSION_MAJOR})

CMakeLists.txt

@@ -119,6 +119,32 @@ int main() {
 }
 ```
 
+---
+
+### Model Enum: Type-Safe Model Selection
+
+llmcpp provides a strongly-typed `OpenAI::Model` enum for selecting models safely and with IDE autocompletion. Example usage:
+
+```cpp
+// Use any supported model from the enum
+auto response = client.sendRequest(OpenAI::Model::O3, "What's new in the O3 model?");
+auto response2 = client.sendRequest(OpenAI::Model::GPT_4_1_Mini, "Summarize this text.");
+```
+
+**Available models:**
+- O3, O3_Mini
+- O1, O1_Mini, O1_Preview, O1_Pro
+- O4_Mini, O4_Mini_Deep_Research
+- GPT_4_1, GPT_4_1_Mini, GPT_4_1_Nano
+- GPT_4o, GPT_4o_Mini
+- GPT_4_5 (preview)
+- GPT_3_5_Turbo (legacy)
+- Custom (for custom/unknown model names)
+
+> **Note:** Model recommendations change frequently. For the latest guidance on which model to use for your use case (reasoning, coding, cost, etc.), consult the [OpenAI model documentation](https://platform.openai.com/docs/models) or your provider's docs. The library no longer provides a built-in recommendation function.
+
+---
+
 ## CMake Integration
 
 ### After install (recommended)

README.md

@@ -130,7 +130,6 @@ class OpenAIClient : public LLMClient {
     static std::string modelToString(OpenAI::Model model);
     static OpenAI::Model stringToModel(const std::string& modelStr);
     static std::vector<OpenAI::Model> getAvailableModelEnums();
-    static OpenAI::Model getRecommendedModelEnum(const std::string& useCase);
 
    private:
     /**